Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update instructions for how to install from source #629

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

wesk
Copy link
Collaborator

@wesk wesk commented Apr 17, 2023

Closes #627

If a better way emerges for how to install from source, will re-open the issue and re-implement.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@wesk wesk requested a review from mseeger April 17, 2023 14:02
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (090bf07) 65.32% compared to head (098021a) 65.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
- Coverage   65.32%   65.29%   -0.04%     
==========================================
  Files         367      367              
  Lines       26680    26680              
==========================================
- Hits        17430    17420      -10     
- Misses       9250     9260      +10     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@mseeger mseeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also explain why this is not a general solution? Is installing the wheel very expensive?

@wesk
Copy link
Collaborator Author

wesk commented Apr 17, 2023

It works, but I'm trying to understand if there is an even better way to do this. Waiting for a response in pypa/setuptools#3894. I just would prefer to not add another step/dependency. But we can update guidance again later if we find another method.

@wesk wesk merged commit 4eac1f4 into main Apr 17, 2023
27 checks passed
@wesk wesk deleted the 2023-04-17-update-docs branch April 17, 2023 14:13
@wesk wesk added the documentation Improvements or additions to documentation label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

follow-up: make sure customers can easily run example scripts
2 participants