Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make sure RemoteLauncher works with requirements.txt which does … #731

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

mseeger
Copy link
Collaborator

@mseeger mseeger commented Jun 26, 2023

…not end with "\n"

Closes #730.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7afdf9b) 65.22% compared to head (5b4bb56) 65.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #731   +/-   ##
=======================================
  Coverage   65.22%   65.22%           
=======================================
  Files         432      432           
  Lines       28936    28936           
=======================================
  Hits        18873    18873           
  Misses      10063    10063           
Impacted Files Coverage Δ
syne_tune/remote/remote_launcher.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mseeger mseeger merged commit 0e0cef4 into main Jun 27, 2023
32 checks passed
@mseeger mseeger deleted the fix_requirements branch June 27, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RemoteLauncher corrupts requirements.txt when not ending with newline
2 participants