Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make sure RemoteLauncher works with requirements.txt which does … #731

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix: Make sure RemoteLauncher works with requirements.txt which does … #731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions syne_tune/remote/remote_launcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,11 @@ def prepare_upload(self):
)
shutil.copy(endpoint_requirements, tgt_requirement)

# add tuner requirements, this will create the req file if it does not exist
# Add tuner requirements, this will create the req file if it does not exist
# The leading "\n" makes sure this works even if the file behind
# ``tgt_requirement`` does not end with "\n"
with open(tgt_requirement, "a") as reqf:
reqf.write("syne-tune[extra]\n")
reqf.write("\nsyne-tune[extra]\n")

def get_source_dir(self) -> Path:
# note: this logic would be better moved to the backend.
Expand Down