Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set maxBodyLength on follow-redirects to match maxContentLength on AxiosOptions #1287

Merged

Conversation

@mividtim
Copy link
Contributor

@mividtim mividtim commented Jan 11, 2018

Set the maxBodyLength on the options sent to follow-redirects to match the AxiosOptions property maxContentLength, so axios can support content lengths greater than 10mb.

Addresses #1286

Tim Garthwaite added 3 commits Jan 11, 2018
…s maxContentLength is not exceeded
Tim Garthwaite
@mividtim
Copy link
Contributor Author

@mividtim mividtim commented Jan 30, 2018

@Khaledgarbaya Please review and merge.

@amsross
Copy link

@amsross amsross commented Feb 6, 2018

pretty please?

@mividtim
Copy link
Contributor Author

@mividtim mividtim commented Feb 6, 2018

Does this project have any active maintainers? I have two open PRs, passing tests, improving functionality, and not a peep for almost a month, after several pings.

@amsross
Copy link

@amsross amsross commented Feb 6, 2018

The commit history doesn't seem too terrible stale, so hopefully it's not dead.

@mividtim mividtim mentioned this pull request Feb 8, 2018
11 of 48 tasks complete
@emilyemorehouse
Copy link
Member

@emilyemorehouse emilyemorehouse commented Feb 11, 2018

There was a call for assistance about a month ago (http://www.mattzabriskie.com/blog/axios-help-wanted). A few of us have stepped up, along with the original owners, and are working hard to get through the backlog of issues and PRs. Bear with us!

Copy link
Member

@emilyemorehouse emilyemorehouse left a comment

This looks good -- I'll also lock the version of follow-redirects as maxBodyLength wasn't supported until 1.3.0. Thanks!

@emilyemorehouse emilyemorehouse merged commit f26e0c0 into axios:master Feb 11, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
emilyemorehouse added a commit that referenced this pull request Feb 11, 2018
Companion for #1286 and #1287 - also updating follow-redirects version in package.json
@mividtim
Copy link
Contributor Author

@mividtim mividtim commented Feb 12, 2018

@emilyemorehouse Sorry for being short. I just started using this project fairly recently, so I must have missed the call to action, or it just didn't reach me on channels I was watching. I'd love to pitch in any way I can. Could you lead me in the right direction?

Thanks for the merge!

@mividtim mividtim deleted the mividtim:mividtim/follow-redirects-max-length branch Feb 12, 2018
@dnfield
Copy link

@dnfield dnfield commented Feb 19, 2018

When will this be part of a released version available through NPM?

Could we at least get a tag for this?

@emilyemorehouse
Copy link
Member

@emilyemorehouse emilyemorehouse commented Feb 19, 2018

@mividtim No worries! The squeaky wheel gets the grease, right? In terms of helping out, I've been trying to clear out the backlog of issues by determining which ones are really bugs and which are issues with a user's implementation. I'll usually start by providing a working example (unless I can reproduce a bug) or even just pinging old issues to see if they'll still respond. Feel free to reach out to me if you want more info or collaboration, I'm quite accessible on the internet.

@dnfield I'll ping the person who's acting as a release manager, we definitely need an updated release.

@emilyemorehouse
Copy link
Member

@emilyemorehouse emilyemorehouse commented Feb 19, 2018

I'm now a person who can cut releases 🤷‍♀️
So... this is released in 0.18.0!

ramijarrar added a commit to fractal-code/meteor-azure that referenced this pull request Mar 5, 2018
Temporary version pinning was shown to be insufficient by #52. Since axios/axios#1287 this is
no longer blocking upstream. Setting 'maxContentLength' now properly resolves this once and for all.
ramijarrar added a commit to fractal-code/meteor-azure that referenced this pull request Mar 5, 2018
Temporary version pinning was shown to be insufficient by #52. Since axios/axios#1287 this is
no longer blocking upstream. Setting 'maxContentLength' now properly resolves this once and for all.
targos added a commit to cheminfo/zenodo that referenced this pull request Apr 11, 2018
jimthedev added a commit to commitizen/cz-cli that referenced this pull request May 24, 2018
This Pull Request updates dependency [axios](https://github.com/axios/axios) from `v0.15.2` to `v0.18.0`



<details>
<summary>Release Notes</summary>

### [`v0.18.0`](https://github.com/axios/axios/blob/master/CHANGELOG.md#&#8203;0180-Feb-19-2018)
[Compare Source](axios/axios@v0.17.1...v0.18.0)
- Adding support for UNIX Sockets when running with Node.js ([#&#8203;1070](`axios/axios#1070))
- Fixing typings ([#&#8203;1177](`axios/axios#1177)):
    - AxiosRequestConfig.proxy: allows type false
    - AxiosProxyConfig: added auth field
- Adding function signature in AxiosInstance interface so AxiosInstance can be invoked ([#&#8203;1192](`axios/axios#1192), [#&#8203;1254](`axios/axios#1254))
- Allowing maxContentLength to pass through to redirected calls as maxBodyLength in follow-redirects config ([#&#8203;1287](`axios/axios#1287))
- Fixing configuration when using an instance - method can now be set ([#&#8203;1342](`axios/axios#1342))

---

### [`v0.17.1`](https://github.com/axios/axios/blob/master/CHANGELOG.md#&#8203;0171-Nov-11-2017)
[Compare Source](axios/axios@v0.17.0...v0.17.1)
- Fixing issue with web workers ([#&#8203;1160](`axios/axios#1160))
- Allowing overriding transport ([#&#8203;1080](`axios/axios#1080))
- Updating TypeScript typings ([#&#8203;1165](`axios/axios#1165), [#&#8203;1125](`axios/axios#1125), [#&#8203;1131](`axios/axios#1131))

---

### [`v0.17.0`](https://github.com/axios/axios/blob/master/CHANGELOG.md#&#8203;0170-Oct-21-2017)
[Compare Source](axios/axios@v0.16.2...v0.17.0)
- **BREAKING** Fixing issue with `baseURL` and interceptors ([#&#8203;950](`axios/axios#950))
- **BREAKING** Improving handing of duplicate headers ([#&#8203;874](`axios/axios#874))
- Adding support for disabling proxies ([#&#8203;691](`axios/axios#691))
- Updating TypeScript typings with generic type parameters ([#&#8203;1061](`axios/axios#1061))

---

### [`v0.16.2`](https://github.com/axios/axios/blob/master/CHANGELOG.md#&#8203;0162-Jun-3-2017)
[Compare Source](axios/axios@v0.16.1...v0.16.2)
- Fixing issue with including `buffer` in bundle ([#&#8203;887](`axios/axios#887))
- Including underlying request in errors ([#&#8203;830](`axios/axios#830))
- Convert `method` to lowercase ([#&#8203;930](`axios/axios#930))

---

### [`v0.16.1`](https://github.com/axios/axios/blob/master/CHANGELOG.md#&#8203;0161-Apr-8-2017)
[Compare Source](axios/axios@v0.16.0...v0.16.1)
- Improving HTTP adapter to return last request in case of redirects ([#&#8203;828](`axios/axios#828))
- Updating `follow-redirects` dependency ([#&#8203;829](`axios/axios#829))
- Adding support for passing `Buffer` in node ([#&#8203;773](`axios/axios#773))

---

### [`v0.16.0`](https://github.com/axios/axios/blob/master/CHANGELOG.md#&#8203;0160-Mar-31-2017)
[Compare Source](axios/axios@v0.15.3...v0.16.0)
- **BREAKING** Removing `Promise` from axios typings in favor of built-in type declarations ([#&#8203;480](`axios/axios#480))
- Adding `options` shortcut method ([#&#8203;461](`axios/axios#461))
- Fixing issue with using `responseType: 'json'` in browsers incompatible with XHR Level 2 ([#&#8203;654](`axios/axios#654))
- Improving React Native detection ([#&#8203;731](`axios/axios#731))
- Fixing `combineURLs` to support empty `relativeURL` ([#&#8203;581](`axios/axios#581))
- Removing `PROTECTION_PREFIX` support ([#&#8203;561](`axios/axios#561))

---

### [`v0.15.3`](https://github.com/axios/axios/blob/master/CHANGELOG.md#&#8203;0153-Nov-27-2016)
[Compare Source](axios/axios@v0.15.2...v0.15.3)
- Fixing issue with custom instances and global defaults ([#&#8203;443](`axios/axios#443))
- Renaming `axios.d.ts` to `index.d.ts` ([#&#8203;519](`axios/axios#519))
- Adding `get`, `head`, and `delete` to `defaults.headers` ([#&#8203;509](`axios/axios#509))
- Fixing issue with `btoa` and IE ([#&#8203;507](`axios/axios#507))
- Adding support for proxy authentication ([#&#8203;483](`axios/axios#483))
- Improving HTTP adapter to use `http` protocol by default ([#&#8203;493](`axios/axios#493))
- Fixing proxy issues ([#&#8203;491](`axios/axios#491))

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
arboehme added a commit to arboehme/directus-sdk-javascript that referenced this pull request Aug 16, 2018
@axios axios locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants