Instance doesn't inherit defaults.baseURL

[franciscolourenco]

https://gist.github.com/aristidesfl/3ee35d0fc449dbff698ffa136d377530
http://requirebin.com/?gist=3ee35d0fc449dbff698ffa136d377530

[franciscolourenco]

The same with other options like timeout and interceptors.

[cannap]

hi you need to set the base url for the new Axios instance are you sure it should inherit?

myAxios.defaults.baseURL = "https://api.icndb.com";

[franciscolourenco]

Thats is what I understood from https://github.com/mzabriskie/axios#config-order-of-precedence
Global defaults get used if instance options are not provided.
If Global defaults are changed with axios.defaults then they should be reflected in instances.

If this is not supported, global defaults is a bit pointless. It would be a nice feature in any case.

[nickuraltsev]

Thank you, @aristidesfl! This is a bug that needs to be fixed asap.

Details

In the current version, axios.defaults is the default instance's config which is not the same as the object exported by the defaults module. Custom instances inherit the latter, but not the former, hence changing axios.defaults has no effect on a custom instance's config.

I think this can be fixed by modifying the axios.create method to merge the default instance config with the specified config as follows:

axios.create = function create(defaultConfig) {
  return createInstance(utils.merge(axios.defaults, defaultConfig));
};

But since there are other issues with configuration (#385, #382, #370), I think it makes sense to address all of them at once . /cc @mzabriskie, @rubennorte

[franciscolourenco]

@nickuraltsev as a workaround I've been using axios.create(axios.defaults) where axios.defaults is the modified defaults.

[yanivefraim]

Is someone working on that? Can I help? (: I would love to continue from here
@nickuraltsev ?

[nickuraltsev]

Fixed via 6d0e193