Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus panics when attempting to resume a deleted session #34

Closed
1 task done
ayoisaiah opened this issue Nov 29, 2023 · 3 comments · Fixed by #35
Closed
1 task done

Focus panics when attempting to resume a deleted session #34

ayoisaiah opened this issue Nov 29, 2023 · 3 comments · Fixed by #35
Assignees
Labels
bug Something isn't working as expected

Comments

@ayoisaiah
Copy link
Owner

Tick this box to confirm you have reviewed the above.

  • I've discovered a new issue with Focus.

What version of Focus are you using?

focus v1.4.2

How did you install Focus?

Go toolchain

What operating system are you using Focus on?

Fedora 39

What is your Focus configuration?

work_mins: 50
work_msg: Focus on your task
short_break_mins: 10
short_break_msg: Take a breather
long_break_mins: 30
long_break_msg: Take a long break
long_break_interval: 4
notify: true
auto_start_work: false
auto_start_break: true
24hr_clock: false
sound: ''
sound_on_break: false
work_sound: loud_bell
break_sound: bell

Describe your bug.

Panic when resuming a deleted session

What are the steps to reproduce the behavior?

  1. Start a new session
  2. Pause session with Ctrl-C
  3. Delete session with focus delete
  4. Type focus resume -s to resume interrupted session (which was just deleted)

What behaviour did you observe?

image

What is the expected behaviour?

Such occurrences could be prevented by deleting all references to the session once it is deleted

@ayoisaiah ayoisaiah self-assigned this Nov 29, 2023
@ayoisaiah ayoisaiah added the bug Something isn't working as expected label Nov 29, 2023
@jonnieey
Copy link

This still occurs in v1.4.2 installed via go toolchain
2024-01-19-181208

@ayoisaiah
Copy link
Owner Author

@jonnieey I can't reproduce it anymore:

image

Can you please provide the steps to reproduce?

Or please upload your log file here (~/.local/share/focus/log/focus.log)

@ayoisaiah
Copy link
Owner Author

@jonnieey Update to v1.4.3 please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants