Fixing PLAINTEXT signature building #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
added a commit
that referenced
this pull request
Jan 21, 2012
Fixing PLAINTEXT signature building
|
Thanks! You're right, and you prove the test server (used in ft_interface) wrong :) I just double checked at http://hueniverse.com/oauth/guide/authentication/ that the '&' should indeed be percent encoded only once. I'll merge your patch right away. Miło, że ktoś ciągle tego używa :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In docs, you've written that PLAINTEXT is not deeply tested. Indeed, I got errors during authorization trials on dropbox.com . The problem is that "&" character is percent-encoded two times: first time in createPlaintextSignature() and second time in createSignature(). With this patch, everything works well.
Dzięki za fajną bibliotekę :)