Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Accordions to Use Flexbox #1207

Open
danahertzberg opened this issue Apr 17, 2024 · 1 comment · May be fixed by #1208
Open

Change Accordions to Use Flexbox #1207

danahertzberg opened this issue Apr 17, 2024 · 1 comment · May be fixed by #1208
Labels
enhancement New feature or request

Comments

@danahertzberg
Copy link
Contributor

danahertzberg commented Apr 17, 2024

Motivation

I want to use flexbox in the display of Accordions to be more.. flexible. And in line with Bootstrap's direction.

Is your feature request related to a problem? Please describe.

Follow up to #1198

Proposed Resolution

Describe the solution you'd like

Change CSS to the flexbox solution and update the Quickstart template to allow for new changes.

SO.. I can't remember how to test locally. BUT I may have a solution. What if we:

  1. Revert to my CSS in this PR
  2. Add the nested hover and span.title css below
    .btn {
       display: flex;
       width: 100%;
       padding: .75rem 1.25rem;
       color: $dark-silver;
       text-align: left;
       text-transform: none;
       justify-content: space-between;
       align-items: center;
    
       &:hover {
         text-decoration: none;
    
         span.title {
             text-decoration: underline;
           }
           
       }
    
  3. Add the <span class="title"> around {{ title }} in the file https://github.com/az-digital/az_quickstart/blob/main/modules/custom/az_accordion/templates/az-accordion.html.twig
@joeparsons
Copy link
Member

We could also consider this being a 5.x only enhancement since Accordions in upstream Bootstrap 5.x already use flexbox.

@joeparsons joeparsons added this to the Arizona Bootstrap 5.0.0 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants