xfd: Adjust portlet tooltip to be more accurate #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amorymeltzer
changed the title
Amorymeltzer
force-pushed
the
xfd-tooltip
branch
from
1eeb7f0
to
22a0cf8
Compare
|
Went option 2 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was briefly discussed on WT:TW, but the portlet tooltip of
Start a deletion discussionis rarely, if ever, sufficiently accurate, and indeed elides and even hides functionality (namely, RM). I've put the two ideas up here:Start a discussionI (clearly) favor the former as being simpler and not duplicating checks, but honestly the more detail from the second is probably nicer and likely to be more popular. It'll be inaccurate if folks choose something else (or in the specific cases of things like userboxes, stubs, etc.) but by the time the module window is open, I don't think anyone cares what the tooltip was.