Feature/kak/update dependencies #1088
Conversation
src/gulpfile.js
Outdated
| .pipe(gulpFilter(filter)); | ||
|
|
||
| if (extraFiles && extraFiles.length > 0) { | ||
| return result.pipe(addsrc(extraFiles)); |
There was a problem hiding this comment.
I was expecting this to just tack on the method (i.e. result = result.pipe...) rather than return, but when there's only one conditional filter it works either way.
There was a problem hiding this comment.
Good point. This check is necessary now, by the way, due to empty collections now resulting in an error if sent to the pipe.
src/bower.json
Outdated
| "js-storage": "~1.0.1", | ||
| "handlebars": "~4.0.12", | ||
| "jquery": "~3.3.1", | ||
| "leaflet": "~1.3.4", |
There was a problem hiding this comment.
This one stands out as a significant jump. Surprising that it didn't break anything.
There was a problem hiding this comment.
The Leaflet dependency depends on the version of leaflet used in the Carto JS library, which has been updated.
There was a problem hiding this comment.
...although I see now the bugfix version is slightly different, so I'll make those match.
There was a problem hiding this comment.
Pinned back to the previous cartodb.js and opened #1089
flibbertigibbet
force-pushed
the
feature/kak/update-dependencies
branch
from
950ccfa
to
b9de498
Compare
Downgrade postgres support library role and psycopg2 binary versions. Upgrading resulted in app VM not connecting to DB.
Now "default" on the module.
flibbertigibbet
force-pushed
the
feature/kak/update-dependencies
branch
from
b9de498
to
72d9b44
Compare
Overview
Update project dependencies for ansible roles, python packages, and Javascript packages.
Notes
Turf exports have changed to provide a top-level
defaultfunction instead of simply exporting the function. I couldn't find a straightforward way to transform thebrowserifybuild to rename the export, so the calls toturfdistanceandpointOnLinehave changed instead.Attempting to update the Postgresql support ansible role version resulted in provisioning failures, perhaps due to the role changing to default to 9.5, so that role is behind a version still.
Testing Instructions
distancefunctionality: set origin on home page; distances should populate on destinationsConnects azavea/urban-apps#173