Add support for supplying Fargate platform version #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectcastro
commented
Oct 10, 2020
| @@ -170,34 +171,29 @@ def run_task(self, config, task_def_arn, security_group_id, subnet_id, cmd): | |||
| taskDefinition=task_def_arn | |||
| )["taskDefinition"] | |||
|
|
|||
| kwargs = { | |||
There was a problem hiding this comment.
Using a kwargs dictionary here aids in removing the task_response code duplication below.
| @@ -1,3 +1,5 @@ | |||
| from setuptools import setup | |||
|
|
|||
| setup(use_scm_version=True,) | |||
| setup( | |||
There was a problem hiding this comment.
Black complained about this during the PR build.
3 tasks
colekettler
approved these changes
Oct 13, 2020
Pass through the platformVersion keyword argument when the configured launchType is FARGATE. In addition, default platformVersion to LATEST.
hectcastro
force-pushed
the
feature/hmc/fargate-platform-version
branch
from
e7955ee
to
892a664
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Pass through the
platformVersionkeyword argument when the configuredlaunchTypeisFARGATE. In addition, defaultplatformVersiontoLATEST.Closes #19
Demo
Testing Instructions
See: opensupplyhub/open-apparel-registry#1129