Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example plugin __init__.py files to include registry.set_plugin_version() calls #1665

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Jan 13, 2023

Overview

All plugins are required to register themselves in the Registry by calling registry.set_plugin_version(). However, currently the example plugins and docs do not make this clear. This PR fixes this oversight.

This was brought up in #1652.

Checklist

  • Added needs-backport label if PR is bug fix that applies to previous minor release
  • Ran scripts/format_code and committed any changes
  • Documentation updated if needed
  • PR has a name that won't get you publicly shamed for vagueness

Notes

N/A

Testing Instructions

See docs build: https://raster-vision--1665.org.readthedocs.build/en/1665/framework/architecture.html#id4

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #1665 (9646afa) into master (95e50f5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 9646afa differs from pull request most recent head 1431dea. Consider uploading reports for the commit 1431dea to get more accurate results

@@            Coverage Diff             @@
##           master    #1665      +/-   ##
==========================================
- Coverage   75.69%   75.68%   -0.02%     
==========================================
  Files         192      192              
  Lines        9254     9254              
==========================================
- Hits         7005     7004       -1     
- Misses       2249     2250       +1     
Impacted Files Coverage Δ
.../rastervision/pipeline_example_plugin1/__init__.py 100.00% <100.00%> (ø)
.../rastervision/pipeline_example_plugin2/__init__.py 100.00% <100.00%> (ø)
...ervision/pytorch_learner/object_detection_utils.py 75.14% <0.00%> (-0.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@AdeelH AdeelH changed the title Update example plugin __init__.py files to include add registry.set_plugin_version() calls Update example plugin __init__.py files to include registry.set_plugin_version() calls Jan 13, 2023
@AdeelH AdeelH requested a review from lewfish January 13, 2023 14:27
@AdeelH AdeelH added the needs-backport This PR needs to be backported to release branches label Jan 17, 2023
@AdeelH AdeelH merged commit 1fc9cd2 into azavea:master Jan 17, 2023
@AdeelH AdeelH deleted the reg_plugin branch January 24, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport This PR needs to be backported to release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants