Skip to content

Commit

Permalink
feat(CMake): Minor CMake Update to Modules Cmake File to Allow Custom…
Browse files Browse the repository at this point in the history
… Modules to make changes without changing Core. (#12846)

* Added in a the ability for module developers to create a cmake file that gets run inline with the module CMakeLists.txt. Minor Perf hit on the build but will allow for Modules to be more flexible in how they work with CMake.

* Comments and Documentation
  • Loading branch information
DavidStrickland0 committed Aug 25, 2022
1 parent 11bac9a commit 8925125
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
5 changes: 5 additions & 0 deletions modules/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,11 @@ target_include_directories(modules
${CMAKE_CURRENT_SOURCE_DIR}
${PUBLIC_INCLUDES})

# Enables Devs to Include a cmake file in their module that will get run inline with the config.
foreach(SOURCE_MODULE ${MODULES_MODULE_LIST})
include("${CMAKE_SOURCE_DIR}/modules/${SOURCE_MODULE}/${SOURCE_MODULE}.cmake" OPTIONAL)
endforeach()

set_target_properties(modules
PROPERTIES
FOLDER
Expand Down
2 changes: 2 additions & 0 deletions modules/how_to_make_a_module.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,5 @@ NOTE: You can also clone our skeleton-module manually, clean the history, and co
3) Share it with the community!

Join us on our discord, share it there, then we might fork it officially and it will appear in the module catalogue.

Note: For Advanced CMake implementations a <ModuleName>.cmake file in your module folder will be included in the config of Modules if it exists. See: ./CMakeList.txt around line #290

0 comments on commit 8925125

Please sign in to comment.