Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coredump #1499

Closed
chendh123 opened this issue Feb 19, 2019 · 7 comments
Closed

coredump #1499

chendh123 opened this issue Feb 19, 2019 · 7 comments

Comments

@chendh123
Copy link

chendh123 commented Feb 19, 2019

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7f2f6a862700 (LWP 51132)]
0x0000000001b110aa in Trinity::Assert (file=0x259d550 "/home/cdh/workspace/azerothcore-wotlk/src/server/game/Grids/Notifiers/GridNotifiersImpl.h", line=540, 
    function=0x259da6f <Trinity::LocalizedPacketDo<Trinity::MonsterChatBuilder>::operator()(Player*)::__FUNCTION__> "operator()", message=0x259d528 "data->GetOpcode() != MSG_NULL_ACTION")
    at /home/cdh/workspace/azerothcore-wotlk/src/common/Debugging/Errors.cpp:20
20          *((volatile int*)NULL) = 0;
(gdb) where
#0  0x0000000001b110aa in Trinity::Assert (file=0x259d550 "/home/cdh/workspace/azerothcore-wotlk/src/server/game/Grids/Notifiers/GridNotifiersImpl.h", line=540, 
    function=0x259da6f <Trinity::LocalizedPacketDo<Trinity::MonsterChatBuilder>::operator()(Player*)::__FUNCTION__> "operator()", message=0x259d528 "data->GetOpcode() != MSG_NULL_ACTION")
    at /home/cdh/workspace/azerothcore-wotlk/src/common/Debugging/Errors.cpp:20
#1  0x000000000153dc0c in Trinity::LocalizedPacketDo<Trinity::MonsterChatBuilder>::operator() (this=<error reading variable: Cannot access memory at address 0xa0a0a0a0a09e2>, 
    this@entry=<error reading variable: Cannot access memory at address 0xa0a0a0a0a0a12>, p=<error reading variable: Cannot access memory at address 0xa0a0a0a0a09da>)
    at /home/cdh/workspace/azerothcore-wotlk/src/server/game/Grids/Notifiers/GridNotifiersImpl.h:540
(gdb)
@Mitradis
Copy link
Contributor

what happened? Write more info.

@FrancescoBorzi
Copy link
Contributor

@chendh123 please add your AC commit hash. The issue will be reopened when you add it.

@robens
Copy link
Contributor

robens commented Feb 19, 2019

this is caused by an assert in grid notifier when talking to npcs. Related to #1342 Could be fixed by doing the port mentioned there.

@chendh123
Copy link
Author

Thanks.
By the way,
if MSG_NULL_ACTION is allowed, why used ASSERT before?

@robens
Copy link
Contributor

robens commented Feb 19, 2019

Actually I just saw that in the pr this assert is moved to worldsession, so is basically the same, they did not remove it. To "fix" this issue one of the following changes could be done:

  • If we don't want servers to just crash when MSG_NULL_ACTION is going to be sent, replace with an error output message and don't send the package.
  • Fix the issue in db, same as DB: Fix crash in waypoint_scripts #1342

This is a msg from server to client, I guess that if it arrives to the client it could cause wowerror or other malfunctions, I never tried it before ^^

@chendh123
Copy link
Author

SHA-1: 3a39aae

@Kitzunu
Copy link
Member

Kitzunu commented Jun 20, 2020

I will close this as we have no reports of it for over a year

@Kitzunu Kitzunu closed this as completed Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants