DB: Fix crash in waypoint_scripts

[Winfidonarleyan]

CHANGES PROPOSED:

• Fix crash in [CRASH] Talking to NPCs in azure watch crashes server #1336

ISSUES ADDRESSED:

Closes #1336

TESTS PERFORMED:

• Tested in game

HOW TO TEST THE CHANGES:

1. Make a new Draenei (any class)
2. Teleport to azure watch .tele azurewatch
3. Talk to NPCs

KNOWN ISSUES AND TODO LIST:

Target branch(es): Master

NOTE: In TC ASSERT(data->GetOpcode() != MSG_NULL_ACTION); delete. Maybe we should delete it too?

• In AC GridNotifiersImpl.h

template<class Builder>
void Trinity::LocalizedPacketDo<Builder>::operator()(Player* p)
{
    LocaleConstant loc_idx = p->GetSession()->GetSessionDbLocaleIndex();
    uint32 cache_idx = loc_idx+1;
    WorldPacket* data;

    // create if not cached yet
    if (i_data_cache.size() < cache_idx + 1 || !i_data_cache[cache_idx])
    {
        if (i_data_cache.size() < cache_idx + 1)
            i_data_cache.resize(cache_idx + 1);

        data = new WorldPacket();

        i_builder(*data, loc_idx);

        ASSERT(data->GetOpcode() != MSG_NULL_ACTION);

        i_data_cache[cache_idx] = data;
    }
    else
        data = i_data_cache[cache_idx];

    p->SendDirectMessage(data);
}

• In TC GridNotifiersImpl.h

template<class Builder>
void Trinity::LocalizedPacketDo<Builder>::operator()(Player* p)
{
    LocaleConstant loc_idx = p->GetSession()->GetSessionDbLocaleIndex();
    uint32 cache_idx = loc_idx+1;
    WorldPacket* data;

    // create if not cached yet
    if (i_data_cache.size() < cache_idx + 1 || !i_data_cache[cache_idx])
    {
        if (i_data_cache.size() < cache_idx + 1)
            i_data_cache.resize(cache_idx + 1);

        data = new WorldPacket();

        i_builder(*data, loc_idx);

        i_data_cache[cache_idx] = data;
    }
    else
        data = i_data_cache[cache_idx];

    p->SendDirectMessage(data);
}

• Diff

- ASSERT(data->GetOpcode() != MSG_NULL_ACTION);

[sucofog]

@Winfidonarleyan TrinityCore/TrinityCore@4073cc5#diff-e55c649851fd21ac6ced06fb292b258f ---> ASSERT(data->GetOpcode() != MSG_NULL_ACTION);

[Winfidonarleyan]

@sucofog oh, yes, I think need to be ported this commit, later. Thanks.

[wetbrownsauce]

Tested.

Artificer Daelo in Azure Watch no longer crashes worldserver when moving along his waypoint, broadcasting text.

[Winfidonarleyan]

@wetbrownsauce Thanks for testing.