Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Core): Crashfix. #11740

Merged
merged 1 commit into from
May 17, 2022
Merged

fix(Core): Crashfix. #11740

merged 1 commit into from
May 17, 2022

Conversation

UltraNix
Copy link
Contributor

Issues Addressed:

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@Yehonal Yehonal added CORE Related to the core file-cpp Used to trigger the matrix build Script labels May 14, 2022
@UltraNix UltraNix added To Be Merged Priority-Critical Server-breaking bugs. Crashes or Exploits CORE Related to the core file-cpp Used to trigger the matrix build and removed CORE Related to the core Script file-cpp Used to trigger the matrix build labels May 14, 2022
@eyeofstorm
Copy link
Contributor

eyeofstorm commented May 15, 2022 •
edited

@UltraNix

This modification may not fix the issue.
According to the crash log, It seems crash at Vehicle.cpp:533.
Which means 'Seats' member of class Vehicle is nullptr.

Addittional information:
In vehicle.dbc, there is no seat defined of entry 337 (referenced by Salvaged Siege Turret(entry 33067) at creature_template).

@UltraNix
Copy link
Contributor Author

UltraNix commented May 15, 2022 •
edited

Vehicle::IsVehicleInUse (this=0x0) at /home/polly/azerothcore/src/server/game/Entities/Vehicle/Vehicle.cpp:533 #3 0x00000000007296ea in npc_salvaged_siege_engine::BeforeSpellClick (this=<optimized out>, clicker=0x7fff4dadb280) at /home/polly/azerothcore/src/server/scripts/Northrend/Ulduar/Ulduar/ulduar.cpp:441
Vehicle::IsVehicleInUse (this=0x0) as you can see, vehicle is null. That crashfix is okay.

@eyeofstorm
Copy link
Contributor

eyeofstorm commented May 15, 2022 •
edited

@UltraNix

Oh, Vehicle::IsVehicleInUse (this=0x0)
You are right, and I am blind.

Salvaged Siege Turret has seat1 defined at vehicle.dbc.

@mpfans mpfans mentioned this pull request May 16, 2022
Closed
@mpfans
Copy link
Contributor

mpfans commented May 17, 2022

tested.

@Kitzunu Kitzunu merged commit c6b5700 into azerothcore:master May 17, 2022
@mpfans mpfans mentioned this pull request May 18, 2022
Closed
eyeofstorm added a commit to eyeofstorm/azerothcore-wotlk that referenced this pull request May 20, 2022
@eyeofstorm
Merge branch 'master' into mod-npc-bots-hooks
2a4fefc 
* master: (31 commits)
  Core/Combat: rename getThreatMgr() to GetThreatMgr() (azerothcore#11758)
  fix(Core/Spells): Windfury, Flametongue, Healing Stream, Cleansing … (azerothcore#11761)
  fix(Core/Spell): Enslaved Demon does not auto-attack/auto-cast (azerothcore#11677)
  chore(DB): import pending files
  fix(DB/Quest): Quest "Relic of the Earthen Ring" should be reset on … (azerothcore#11755)
  fix(Core/Spells): The Earthshatterer 8/9 set bonus should be removed … (azerothcore#11757)
  chore(DB): import pending files
  fix(DB/Spells): Fixed Shaman's Clearcasting proc. (azerothcore#11754)
  chore(DB): import pending files
  fix(DB/Gossips): Earthcaller gossips (azerothcore#11792)
  chore(DB): import pending files
  fix(DB/Quest): Coward Delivery... Under 30 Minutes or it's Free (azerothcore#11734)
  fix(DB/Creature): Goblin Land Mine playing Hakkar voiceline  (azerothcore#11756)
  fix(Core/Scripts): Black Template Area Boundary (azerothcore#11705)
  fix(DB/SAI): Fixed crystal fang to spawn 4 spiders on death (azerothcore#11732)
  refactor(Core/Combat): implement compatiblity layer for ResetAllThreat() (azerothcore#11778)
  fix(DB/Creature): Hakkar should be taunt immune.  (azerothcore#11777)
  fix(Core/Spells): Priest with Spirit of Redemption should be immediat… (azerothcore#11771)
  fix(Core): Crashfix. (azerothcore#11740)
  fix(Core): Crashfix. (azerothcore#11741)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kitzunu Kitzunu Kitzunu approved these changes

@acidmanifesto acidmanifesto Awaiting requested review from acidmanifesto

@Nefertumm Nefertumm Awaiting requested review from Nefertumm

@Nyeriah Nyeriah Awaiting requested review from Nyeriah

Assignees
No one assigned
Labels
CORE Related to the core file-cpp Used to trigger the matrix build Priority-Critical Server-breaking bugs. Crashes or Exploits To Be Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[server] world server crash 0511
5 participants
@UltraNix @eyeofstorm @mpfans @Kitzunu @Yehonal