fix(Core/Combat): Removed UNIT_FLAG_IMMUNE_TO_PC when entering comb…
#12288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at with player. Fixes azerothcore#12211 Fixes azerothcore#12214 Fixes azerothcore#12219 Fixes azerothcore#12212
|
Please merge directly |
|
|
You can merge it and the conflict goes away |
|
tested and wrok |
|
Thank you for the PR |
acidmanifesto
approved these changes
Jul 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…at with player.
Fixes #12211
Fixes #12214
Fixes #12219
Fixes #12212
Issues Addressed:
The Eye of Eternityunable to start battle #12211Razorscale#12214ThorimCombat bug #12219Shadow Vault Decreebug #12212Tests Performed:
How to Test the Changes:
.go xyz 3864.879883 6987.100098 152.042007 571enter The Eye of Eternity
Touch 'the Focusing Iris'
.go c id 33210Dialog 'expedition commander'
start Thorim combat
1
.q a 129432.
.go c id 299193. use Shadow Vault Decree
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.