fix(MMAP/core/PathGenerator): Try to fix more water creatures

[MikaMauger]

This reverts commit 66e6d33.

Changes Proposed:

• Fix a lot of water creatures by reverting aforementioned PR, recast doesn't handle very well underwater terrain, above water terrain and water itself as connected, resulting in creatures using weird path or not be able to compute a path at all
• Check TrinityCore PR for more information
• Water creatures should follow you in a more straightforward way.
• Water creatures should continue to attack you even if you have waterwalk and/or are jumping in water (which was partially fixed by fix(Core/Movement): Water-bound creatures should not evade if their t… #12112, thanks to @UltraNix )

Issues Addressed:

• Closes [Rather be Fishin'] Eels cannot swim upward to attack you #13551
• Closes Makrura Clacker and Surf Crawler buggy movement and sometimes freezing inside the water #6784
• Closes [ZG] Gahz'ranka is going to far away to pull position after summon #12411
• Closes [Live][ZG] Gahz'ranka is going to far away to pull position after summon chromiecraft/chromiecraft#3793

Tests Performed:

• Before: path is wrong
  
• After: path is ok
  
• Before: can't even find a path
  
• Before: When attacking from range, he gets stuck then evades/resets
  
• After: path is ok
  

If you want to see what happens in RecastDemo:

How to Test the Changes:

1. .go xyz -9243.936523 -2453.144531 56.821400 and do range attacks on murlocs from beach when they are in water
2. .go xyz -9250.759766 -1182.086792 67.439095 and do range attacks on murlocs from beach when they are in water
3. A lot more locations where there is a river or a beach/coast

Known Issues and TODO List:

• We need to find a way to handle underwater floor correctly, not very useful for 3.3.5, but definitely needed for cataclysm zones like Vashj'ir, which is not the target for AzerothCore anyway
• This PR doesn't fix the abrupt transitions between movement/attacks of water NPCs / hiccups.

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[MikaMauger]

You'll need to regenerate mmaps in order to get the fix.

[PkllonG]

It's really much better

[PkllonG]

They will also follow the players from the "water surface" to the "water“

[acidmanifesto]

i'm going to mention this so there is no rush with people thinking this is some golden unicorn end all.
There is a issue with this.
As current where it stands is water mobs that can walk on land can not be pulled from the water to land.
They end up evading instead.
Maybe we will have less issues then current. or maybe we will have more issues reported over time.
Weigh the Pro's and Con's first and see if this can be adjusted to fix the issue, if not then a internal discussion will be needed in either correcting the pr, taking it as is, or closing it.

[acidmanifesto]

Also in reference to a screen shot earlier. NPC is swimming above the water surface.

[Gultask]

Also in reference to a screen shot earlier. NPC is swimming above the water surface.

I think that's the normal running animation

[Gultask]

If anyone can. Please try:

1. Checking Gazh'ranka
   .additem 19975 20
.additem 19974 4
.go xyz -11695 -1770 13 309 Teleports to Pagle's Pointe
   Use item, try to pull from the land in one instance, see the whole path taken in the other.

2. This issue: [Rather be Fishin'] Eels cannot swim upward to attack you #13551

.go xyz -4051.062988 2796.326172 -2 1
.npc add temp 5462
move to land, do ranged attacks against it, see if it evades after a while

.go xyz -94.3 -1116.1 35.1 0
Attack snapjaw.
See no evade

[MikaMauger]

1. Gazh'ranka

• before:
  
  1.-.Gazhranka.Before.mp4
• after:
  
  1.-.Gazhranka.After.mp4

2. Eels

• before:
  
  2.-.Eels.Before.mp4
• after:
  
  2.-.Eels.After.mp4

3. Water elem

• before:
  
  3.-.Water.Elem.Before.mp4
• after:
  
  3.-.Water.Elem.After.mp4

4. Snapjaw

• before:
  
  4.-.Snapjaw.Before.mp4
• after:
  
  4.-.Snapjaw.After.mp4

[MikaMauger]

Also in reference to a screen shot earlier. NPC is swimming above the water surface.

I think that's the normal running animation

Indeed, he's just running here. The water effect on his feet always appear until NPC is fully on land.

[PkllonG]

Feels better than before

[Gultask]

I've been testing for quite a while now and everything I can think of is much better than what it was. No regressions that I can see.
None of the problems reported in TC, either.

[Nefertumm]

Removed blank space causing issues on CI

[smellbee]

when this will be merged?

[StraysFromPath]

I have tested this edit and it is a huge improvement fixing murlocs across darkshore and westfall.

[heyitsbench]

What is the status on this?

[Nyeriah]

What is the status on this?

It's going to be merged after the holidays.

[Annamaria-CC]

@MikaMauger

I updated the MMAP version so the core will complain when old files are used

[Gultask]

Thank you very much for the amazing fix, @MikaMauger !

[Annamaria-CC]

Yes its looking good so far :)