feat(Core/Unit): Combat pulse #14792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick: *TrinityCore/TrinityCore@d57193d Co-authored-by: Treeston <treeston@users.noreply.github.com>
yehonal-bot
added
CORE
ghost
changed the title
Nyeriah
approved these changes
Jan 29, 2023
Nyeriah
approved these changes
Feb 5, 2023
ghost
deleted the
Tennesseej
pushed a commit
to Tennesseej/azerothcore-wotlk
that referenced
this pull request
Feb 27, 2023
Co-authored-by: Treeston <treeston@users.noreply.github.com>
This was referenced Aug 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
Issues Addressed:
Closes [AQ40] Princess Huhuran does not aggro whole raid #13554
Closes [AQ40] Bug Trio does not aggro whole raid #13557
Closes [AQ40] Sartura does not aggro whole raid #13556
Closes [AQ40] Twin Emperors do not aggro whole raid #13555
Part of Rewrite combat and threat system to be mutual from TC #5985
SOURCE:
TrinityCore: TrinityCore/TrinityCore@d57193d
Tests Performed:
How to Test the Changes:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.