Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Core/DB): port WarheadCore database #16659

Closed
wants to merge 10 commits into from

Conversation

Winfidonarleyan
Copy link
Member

@Winfidonarleyan Winfidonarleyan commented Jul 2, 2023

Changes Proposed:

  • Added support dynamic connections
  • Using base class for connections instead of template
  • Using smart poiner for PreparedStatement

Issues Addressed:

SOURCE:

Tests Performed:

  • Build, in-game
  • This changes tested in live servers with 10-60 playes (With WH core)

How to Test the Changes:

  • Need a stress test of these changes on the server with the players

Deps modules

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@yehonal-bot yehonal-bot added CORE Related to the core file-cpp Used to trigger the matrix build Script labels Jul 2, 2023
@Winfidonarleyan Winfidonarleyan marked this pull request as ready for review July 2, 2023 12:04
@Kitzunu
Copy link
Member

Kitzunu commented Jul 2, 2023

What is the benefit for this?

@Winfidonarleyan
Copy link
Member Author

Winfidonarleyan commented Jul 2, 2023

What is the benefit for this?

Performance. And now can make new db in modules (need test anyway) :D

@Kitzunu
Copy link
Member

Kitzunu commented Jul 2, 2023

We love performance 😎

@Winfidonarleyan
Copy link
Member Author

We love performance sunglasses

Everyone loves it, but it takes a lot of testing.

@Kitzunu
Copy link
Member

Kitzunu commented Jul 2, 2023

And now can make new db in modules (need test anyway) :D

Now this is cool

@Kitzunu
Copy link
Member

Kitzunu commented Jul 2, 2023

That should be documented though imo

@Winfidonarleyan
Copy link
Member Author

That should be documented though imo

Absolutely, have to test everything first.

@heyitsbench
Copy link
Contributor

Modules gonna need updating. 😬

@Winfidonarleyan
Copy link
Member Author

Modules gonna need updating. 😬

yes yes

@Winfidonarleyan
Copy link
Member Author

Update modules

@walkline
Copy link
Contributor

walkline commented Aug 9, 2023

I understand that this might exceed the current scope, and it's more like my stream of consciousness. But if we could connect to multiple character databases, bind them to players, and incorporate PR with clustering support, we might be close to a cross-realm implementation.

@Kitzunu
Copy link
Member

Kitzunu commented Sep 17, 2023

Status?

@Winfidonarleyan
Copy link
Member Author

Need time :D

@Nyeriah Nyeriah added the PR Abandoned Original author stopped working on this PR. Feel free to take over. label Jan 14, 2024
@Nyeriah
Copy link
Member

Nyeriah commented Jan 14, 2024

Please reopen when continue

@Nyeriah Nyeriah closed this Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE Related to the core file-cpp Used to trigger the matrix build PR Abandoned Original author stopped working on this PR. Feel free to take over. Script Waiting to be Tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[server]world server crash 0109
6 participants