Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npc and quest #16684

Closed
wants to merge 42 commits into from
Closed

Npc and quest #16684

wants to merge 42 commits into from

Conversation

Deflowdk
Copy link

@Deflowdk Deflowdk commented Jul 7, 2023

Changes Proposed:

Issues Addressed:

  • Closes

SOURCE:

Tests Performed:

How to Test the Changes:

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@yehonal-bot yehonal-bot added Bash CORE Related to the core DB related to the SQL database file-cpp Used to trigger the matrix build Workflow Workflow related labels Jul 7, 2023
@elthehablo
Copy link
Contributor

Please fill in PR form properly and clarify what you are fixing in the title

@elthehablo elthehablo added WIP Work in Progress. Waiting For More Info from Author Issue pending due to needing more additional informatino from the author labels Jul 7, 2023
@elthehablo
Copy link
Contributor

Also looks like you uploaded all your modules with it

@elthehablo
Copy link
Contributor

Closing due to having too much tracked garbage and invalid PR form. Please re-upload with valid PR form and only useful tracked changes

@elthehablo
Copy link
Contributor

Nvm I can't xD

@Tereneckla Tereneckla closed this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bash CORE Related to the core DB related to the SQL database file-cpp Used to trigger the matrix build Waiting For More Info from Author Issue pending due to needing more additional informatino from the author WIP Work in Progress. Workflow Workflow related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants