fix(Core/Player): Allow to swap bags when they are filled

[Kitzunu]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

If your pull request promotes complex changes that require a detailed explanation, please describe them in detail specifying what your solution is and what is it meant to address.

Issues Addressed:

• Closes Cannot swap bags unless old bag is empty  #17084
• closes Dropin replacement of bags not possible if not empty chromiecraft/chromiecraft#6070

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Nyeriah]

Need check if bag can hold all items e.g smaller bag and also if it’s appropriate e.g soul bag mining bag etc

[Kitzunu]

I tested swapping big filled bag to small filled bag, don't work. So that is good.
I also tested switching normal bag to mining bag. Dont work, so also good

[heyitsbench]

Interestingly I've tried switching a felcloth bag with an herb bag in this situation, and it gave this error, which doesn't sound correct - testing on Classic indicates this is the correct error. Still need to check with bank bags.

[Kitzunu]

I also tested filled mining bag (20slot), to normal bag (20slot), to mining bag. Works too

[Kitzunu]

As for swapping mining bag onto bag with normal items on it, it gives the same error bench got. So that is good I guess

caught here

azerothcore-wotlk/src/server/game/Entities/Player/PlayerStorage.cpp

Lines 3861 to 3865 in aea5401

	if (!bagItemProto || !ItemCanGoIntoBag(bagItemProto, emptyProto))
	{
	// one from items not go to empty target bag
	SendEquipError(EQUIP_ERR_NONEMPTY_BAG_OVER_OTHER_BAG, pSrcItem, pDstItem);
	return;

[heyitsbench]

Bank-wise, I've swapped bags between existing bags in the bank: the items don't leave the bag they were in before the swap. I've swapped bags between a bag in my backpack and one in the bank, the item in the bank bag stays in the bank bag in the position post-swap. If too many items are in the bank bag to swap into the new bag, it gives the error These items cannot be swapped. Seems to yield the same results with specialized bags as in the normal inventory. (e.g. the aforementioned herb bag/felcloth bag swap circumstance) All looks good. 👍

[elthehablo]

Don't forget to include CC issue

[Kitzunu]

If you see me forget it, please at least link the issue for me in the comment so I don't have to go looking for it. I don't work for cc 🤷