DB - Elwyn Forest loot #1715
Merged
DB - Elwyn Forest loot #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ELdoBA
reviewed
Apr 11, 2019
ELdoBA
reviewed
Apr 11, 2019
| (6, 11111, 11111, 0.5, 0, 1, 0, 1, 1, NULL); -- Bags | ||
|
|
||
| -- Kobold Worker | ||
| DELETE FROM `creature_loot_template` WHERE `Entry`=257; |
There was a problem hiding this comment.
Also for these where you use Entry
There was a problem hiding this comment.
I think the statements are fine as they are, easier to read and better documented if they are structured in blocks for each creature. I also do the same in my PRs.
ELdoBA
reviewed
Apr 11, 2019
| INSERT INTO `version_db_world` (`sql_rev`) VALUES ('1555017745656363300'); | ||
|
|
||
| -- Item should only drop from Riverpaw Mongrel (123) | ||
| DELETE FROM `reference_loot_template` WHERE `Item`=821; |
There was a problem hiding this comment.
I mean for these, miss click in previous comment 😄
There was a problem hiding this comment.
You're right, tomorrow i will be home for that
There was a problem hiding this comment.
I think the statements are fine as they are, easier to read and better documented. No need to merge them into one statement in my opinion.
ghost
approved these changes
Apr 12, 2019
Did also check the old and new DB entries, seems to be ok. I think this is ready to be merged. |
ghost
added
thanhtong89
pushed a commit
to thanhtong89/azerothcore-wotlk
that referenced
this pull request
May 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from trinitycore
CHANGES PROPOSED:
It includes two unique items:
Riverpaw Leather Vest (821) is a unique drop from Riverpaw Mongrel.
Hard Crawler Carapace (2087) is a unique drop from Sand Crawler.
It also includes a crafted item that should never drop anywhere:
Embossed Leather Vest (2300)
TESTS PERFORMED:
Didn't test yet
Target branch(es):
Master