Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Core/Network): Add Proxy Protocol v2 support. #18839

Merged
merged 4 commits into from
May 4, 2024

Conversation

walkline
Copy link
Contributor

In some cases, you may want to place the authserver or worldserver behind a proxy or load balancer. However, if you do this, you would lose the client's address (IP). To address this issue, most proxies and load balancers support Proxy Protocol (v1 & v2). To utilize it, we also need Proxy Protocol support on both the authserver and worldserver.

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

I used HAProxy to test this change.

  1. I changed authserver and worldserver configs by changing ports (3777 & 8026) and by enabling Proxy Protocol.
  2. Run HAProxy with the next config:
global
    log /dev/log    local0
    log /dev/log    local1 notice
    stats timeout 30s

defaults
    log global
    mode tcp
    option tcplog
    timeout connect 5000ms
    timeout client 50000ms
    timeout server 50000ms

frontend tcp_front
    bind 0.0.0.0:3724
    default_backend tcp_back

frontend tcp_world
    bind 0.0.0.0:8085
    default_backend tcp_world_back

backend tcp_back
    server backend_server 127.0.0.1:3777 send-proxy-v2

backend tcp_world_back
    server backend_server 127.0.0.1:8026 send-proxy-v2
  1. Login to the game using regular ports.
  2. You can use .lookup ip command to verify players IP.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added CORE Related to the core file-cpp Used to trigger the matrix build labels Apr 27, 2024
@Nyeriah Nyeriah merged commit 9815025 into azerothcore:master May 4, 2024
16 checks passed
ikkj pushed a commit to ikkj/AzerothCore-wotlk-with-NPCBots that referenced this pull request Jun 10, 2024
* feat(Core/Network): Add Proxy Protocol v2 support.

* Fix codestyle and build.

* Another codestyle fix.

* One more missing include.
ikkj pushed a commit to ikkj/AzerothCore-wotlk-with-NPCBots that referenced this pull request Jun 13, 2024
* feat(Core/Network): Add Proxy Protocol v2 support.

* Fix codestyle and build.

* Another codestyle fix.

* One more missing include.
ikkj pushed a commit to ikkj/AzerothCore-wotlk-with-NPCBots that referenced this pull request Jun 13, 2024
* feat(Core/Network): Add Proxy Protocol v2 support.

* Fix codestyle and build.

* Another codestyle fix.

* One more missing include.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE Related to the core file-cpp Used to trigger the matrix build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Network support proxy protocol
2 participants