Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added capability to import custom data files #18841

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lanathlor
Copy link

@lanathlor lanathlor commented Apr 28, 2024

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

I found no easy way to inject custom .dbc file in worldserver container on a running server. This change add a container using rsync to merge custom data files with existing ones.

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.
  1. add custom .dbc files in ./env/dist/custom-data/dbc
  2. run docker-compose up -d
  3. run docker exec -it ac-worldserver ls /azerothcore/env/dist/data/dbc
  4. the custom .dbc file should be here

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@michaeldelago michaeldelago self-assigned this May 13, 2024
@michaeldelago
Copy link
Contributor

Hey, thanks for your pull request.

Unfortunately, I'm not sure that we can accept this pull request, as custom data isn't something directly supported by the project. The configurations for the Dockerfile and the compose file target a "standard" deploy of AzerothCore, with the most custom changes being AzerothCore modules. I recommend moving your changes to a docker compose override file, and then committing that file to a fork of this repo.

I'd be happy to defer to the input of other AzerothCore maintainers, but I think this PR is safe to close out.

Thank you for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants