-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DB/Loot): Correct Zul'Aman prisoner loot. #18869
Conversation
Do note that because of the linked issue affecting AC, one prisoner is not spawned at all and one is both statically spawned and summoned during the raid. Because of this, four chests do get created and this PR can be tested, but if the chests were handled differently or fewer prisoners could be created, it would be possible that only three loot templates could be generated instead of four. |
Bench making a pr?! |
gib review |
review gibben |
* Init. Co-Authored-By: AnonXS <19734826+anonxs@users.noreply.github.com> * Adjust variable spacing. --------- Co-authored-by: AnonXS <19734826+anonxs@users.noreply.github.com>
* Init. Co-Authored-By: AnonXS <19734826+anonxs@users.noreply.github.com> * Adjust variable spacing. --------- Co-authored-by: AnonXS <19734826+anonxs@users.noreply.github.com>
* Init. Co-Authored-By: AnonXS <19734826+anonxs@users.noreply.github.com> * Adjust variable spacing. --------- Co-authored-by: AnonXS <19734826+anonxs@users.noreply.github.com>
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.