Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/Creature): Correct TBC boss gold rewards. #18899

Merged
merged 6 commits into from
May 19, 2024

Conversation

heyitsbench
Copy link
Contributor

Changes Proposed:

This PR proposes changes to:

  • Database (i.e. creatures).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)

Tests Performed:

This PR:

  • Does not require in-game testing.

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@heyitsbench
Copy link
Contributor Author

If anyone would like to see what name these creatures have or what they drop on current master, you can check this commit.

@github-actions github-actions bot added the DB related to the SQL database label May 15, 2024
@elthehablo elthehablo merged commit 346456f into azerothcore:master May 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database To Be Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants