fix(Unit/ProcessTerrainStatusUpdate): prevent removal swimming auras if swimming

[sogladev]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

azerothcore-wotlk/src/server/game/Entities/Unit/Unit.cpp

Line 4223 in ef6db03

// remove appropriate auras if we are swimming/not swimming respectively

Current logic to decide if swimming is based on GetLiquidData().Status . However, in the coilfang tunnel some parts are LIQUID_MAP_NO_WATER which allows the player to breathe underwater.

Should swimming/noswimming logic be based on MOVEMENTFLAG_SWIMMING flags? Similar to how IsFlying() is handled

Issues Addressed:

• Closes Tunnel to Coilfang Reservoir removes Aquatic Form #14562

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

.tele coilfang
.learn 1066 aquatic form

breath timer indicates which areas are breathable, no liquid

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[sogladev]

is this related to

• [Druid] Exploit allows attacking from the air #18864 ?

[PkllonG]

Tested dcafa28

[sudlud]

can you also please merge master again here for CI