Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): bump dependencies for usage of Node.js 20 #18914

Merged
merged 2 commits into from
May 19, 2024

Conversation

sudlud
Copy link
Member

@sudlud sudlud commented May 18, 2024

our workflows are currently filled with the warning:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Therefore we should upgrade to actions/cache@v4 with Node.js 20 now: https://github.com/marketplace/actions/cache?version=v4.0.2
And also hendrikmuhs/ccache-action: https://github.com/hendrikmuhs/ccache-action/releases/tag/v1.2.13

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

our workflows are currently filled with the warning:
```
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
```

Therefore we should upgrade to actions/cache@v4 with Node.js 20 now:
https://github.com/marketplace/actions/cache?version=v4.0.2
@sudlud sudlud added the run-build Used to trigger the windows/mac/docker and matrix builds label May 18, 2024
@github-actions github-actions bot added the Workflow Workflow related label May 18, 2024
@sudlud sudlud changed the title fix(CI): bump actions/cache to v4 for usage of Node.js 20 fix(CI): bump CI dependencies for usage of Node.js 20 May 18, 2024
@sudlud sudlud changed the title fix(CI): bump CI dependencies for usage of Node.js 20 fix(CI): bump dependencies for usage of Node.js 20 May 18, 2024
@sudlud sudlud merged commit 77397f0 into azerothcore:master May 19, 2024
23 checks passed
@sudlud sudlud deleted the ci-fix-nodejs-warnings-1 branch May 19, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to be Reviewed run-build Used to trigger the windows/mac/docker and matrix builds To Be Merged Workflow Workflow related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants