Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): fix ubuntu-24.04 build #18984

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

sudlud
Copy link
Member

@sudlud sudlud commented May 31, 2024

caused by actions/runner-images#9937

also CI should never attempt a restart as this will always disconnect the CI worker as it seems

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@sudlud sudlud changed the title fix(CI): try to fix ubuntu-24.04 build fix(CI): fix ubuntu-24.04 build May 31, 2024
@sudlud sudlud added To Be Merged Ready to be Reviewed run-build Used to trigger the windows/mac/docker and matrix builds labels May 31, 2024
@sudlud sudlud merged commit 9499100 into azerothcore:master Jun 1, 2024
26 of 29 checks passed
@sudlud sudlud deleted the try-to-fix-ubuntu-24-04-build-1 branch June 1, 2024 09:00
ikkj pushed a commit to ikkj/AzerothCore-wotlk-with-NPCBots that referenced this pull request Jun 10, 2024
fix(CI): try to fix ubuntu-24.04 build
ikkj pushed a commit to ikkj/AzerothCore-wotlk-with-NPCBots that referenced this pull request Jun 13, 2024
fix(CI): try to fix ubuntu-24.04 build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to be Reviewed run-build Used to trigger the windows/mac/docker and matrix builds To Be Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants