-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Scripts/ZulAman): Nalorakk refactored #19010
Conversation
Good, but I find there are some door object miss in database, such as the 4 boss, player can come form back door. |
Our team will likely be working on this somewhere in the next couple of months. Make sure to report the issues if they haven't already been reported. Anyway, this is probably out of the scope of this PR. |
Review pls |
If I near the boss , change to GM mode, then logout game. wait the instance free from the memory(I set to 2 min so veryfast), then logon, remove the gm Status near the boss ,It always work ok. So might the distance with the play judge might have problem? |
And there are some delay now way. if kill the creature much fast, the boss still wait for finishing the now Status. |
Simplified the gauntlet quite a bit. Also used some information from sniffs, like some extra text.
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.