fix(DB/Quest): Hellfire Fortifications #2301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes PVP Flag
FrancescoBorzi
approved these changes
Sep 22, 2019
There was a problem hiding this comment.
@wizzymore I've improved your code a bit, please have a look at my changes
|
I don't think that what is proposed in this PR is correct. As far as I remember this from retail TBC / WotLK you had to manually enable PvP in order to complete those quests. This is also confirmed by some of the wowhead comments, e.g.: |
|
Indeed, as seen in this video there is no need for the flag, my mistake on this as it required some digging to find someone who didn't had PVP turned on when tooking the quest. |
|
Thanks for the video. Tried to find one myself, but as you mentioned most people already had PvP on when taking the quest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES PROPOSED:
ISSUES ADDRESSED:
TESTS PERFORMED:
HOW TO TEST THE CHANGES:
.go c 65556
Take first quest and complete it and then you will have 10110 or 10106 and when you accept it you will have the PVP Flag option
KNOWN ISSUES AND TODO LIST:
Target branch(es):
How to test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR