fix(DB/Core) Fix the CLS damage system and update creature_classlevelstats #4749

Hacki95 · 2021-03-07T15:45:22Z

Fix the CLS damage calculation system and update creature_classlevelstats accordingly

Changes Proposed:

Reenable the min/max damage CLS system in Creature::SelectLevel in Creature.cpp that has been disabled
Fix the underlying calculation issue in Creature::CalculateMinMaxDamage in StatSystem.cpp. AttackMultiplier was wrongfully multiplied with AttackSpeed. I used the reverse engineered CLS calculations TC/vmangos/cmangos use.
Correct several wrong values in creaure_classlevelstats. Multiple damage_base and attackpower values were wrong before. I imported those values from TC's database.
Correct several wrong DamageModifier values in creature_template. Using TC values for those aswell. The values we had before were mostly a flat 1 or completly off because they were based on the old system. With the new values the calculations lead to the desired result.
Drop "mindamage", "maxdamage", "minrangedamage", "maxrangedamage", "attackpower" and "rangedattackpower" from creature_template as those values aren't needed anymore.
Fix all code that references those columns.
Implement BaseVariance and RangeVariance (mostly for custom mobs).

Issues Addressed:

Closes Update the creature damage system to CLS, too many issues currently. [$50 awarded] #4570
While no other issues are open at the moment, using the CLS calculation instead of using fixed min/max values could potentially fix a lot of NPCs which had wrong sniffed data before. This bug existed since Commit 1 of AzerothCore :)

Tests Performed:

Tested "reload creature_template".
Used the Spell "Beast Lore (ID=1462) on around 20 different mobs to check their min/max damage values. Those values now correctly change if a mob is for example Level 35 vs Level 36. All values I tested so far have been ~99% to the pre-calculated min/max values so it seems like the new damage_base values are correct or atleast much better than the values we had before.
Played for a few hours on my offline realm and everything I tried looks great.

How to Test the Changes:

Download the PR, compile the code and apply the DB update.
Make a Hunter or simply learn spell 1462.
Fly around the world and check the mobs min/max attack values.

Known Issues and TODO List:

I have no way to confirm the values I took from TC are 100% accurate. BUT they are way better than the precalculated values we used before and every mob I tested has been correct.

Target Branch(es):

Master

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

- Re enable the CLS dmg calculation. - Fix the error in how min/max dmg are calculated - Update a bunch of values for damage_base and attackpower which have been wrong before - Remove min/maxdmg and min/maxrangedmg from creature_template as they aren't used anymore.

FrancescoBorzi · 2021-03-07T16:20:14Z

@T1ti

src/server/game/Entities/Unit/StatSystem.cpp

PkllonG · 2021-03-07T19:43:27Z

After the test, I felt the damage value was higher
player level 70
.go c id 17711
before 10000-15000
after 15000-20000
Maybe that's the right damage?

T1ti · 2021-03-07T19:57:47Z

After the test, I felt the damage value was higher
player level 70
.go c id 17711
before 10000-15000
after 15000-20000
Maybe that's the right damage?

It's still WIP, dmg modifier is not updated yet. This creature you're testing has 35 dmg modifier and modifiers work differently between the two systems

You can try creatures that have x1 dmg modifier for now

Also he hasn't updated BC/Wrath values yet

src/server/scripts/Commands/cs_reload.cpp

- Values from TC

Hacki95 · 2021-03-07T22:39:30Z

Added the missing DamageModifiers for Elite mobs/Bosses etc. And I removed the line from cs_reload()

T1ti · 2021-03-08T07:24:25Z

It's looking good. Different levels have different values as it should

I have tested some creatures dmg like magmadar which are off (even on TC) and will need to be corrected

But this system makes it VERY easy to find the right values and blizzard most of the time uses a simple number. (since we now use the same system as blizz)
For example, modifier 17 gives the exact correct value for magmadar
(I made a sheet formula
)

-You need to delete the attack power column in creature_template and load the creature's AP from the CLS
-One column which is not entirely necessary but nice to give some flexibility to users, is to add a "variance" column, to let the users having custom damage range and not always max = min*1.5 (I saw someone complaining about that) TC already has that implemented.

But otherwise it looks pretty good atm, is off hands calculated properly ? TC did several commits for it.
Good job !

Hacki95 · 2021-03-08T10:03:53Z

I will take a look at the Attackpower column.
Should I fix the value for Magmadar in this PR?

Also about the variance, I might implement this but I am not sure yet. Mainly because I am not 100% sure how this mechanic is supposed to work.
float baseValue = GetFlatModifierValue(unitMod, BASE_VALUE) + (attackPower / 3.5f) * variance;
Variance is multiplied with the baseValue and not directly for the maxdmg. I think this needs some more research before I would blindly copy those lines without understanding if blizz had something like this. Maybe this is something for another PR but I will take a look.

About Off-Hands I am tbh not 100% sure, I assumed our calculations are already correct for this. I will double check!

Thanks for the feedback I appreciate it.

PkllonG · 2021-03-08T11:54:36Z

src/server/scripts/Commands/cs_reload.cpp

-            cInfo->lootid             = fields[43].GetUInt32();
-            cInfo->pickpocketLootId   = fields[44].GetUInt32();
-            cInfo->SkinLootId         = fields[45].GetUInt32();
+            cInfo->DifficultyEntry[0]       = fields[1].GetUInt32();


Or wrong, it should start from 0
cInfo->DifficultyEntry[0] = fields[0].GetUInt32();

You are right I had an error in my thinking here, will update now

PkllonG · 2021-03-08T12:02:25Z

It's a good damage calculation system, we should finish it anyway

Hacki95 · 2021-03-08T12:10:41Z

It's a good damage calculation system, we should finish it anyway

Are you talking about the variance system or in general? I need some input if I should add that or better leave it out for now.

PkllonG · 2021-03-08T12:12:35Z

I'm talking about current pr

src/server/scripts/Commands/cs_reload.cpp

PkllonG · 2021-03-08T12:22:39Z

If you need to test anything, please let me know

Hacki95 · 2021-03-08T12:24:49Z

If you need to test anything, please let me know

If you know how we could test if the Off-Hand damage is calculated correctly that would be really useful.

PkllonG · 2021-03-08T12:26:55Z

I'm afraid I can't help you. I'm just a tester. My coding knowledge is too poor

Hacki95 · 2021-03-08T12:30:52Z

I meant by testing if the values seem to be correct, I dont even know which NPCs I could check :D But no problem. maybe @T1ti has an idea.

PkllonG · 2021-03-08T12:33:20Z

I think we should restore all previously changed DamageModifier values

Footman · 2021-03-16T11:16:42Z

Like I said I got feedback from top Raid groups in 25 heroic mode. They were very angry and have never seen such high damage on other servers. A lot of creatures do too much damage that tanks with top Gear can't keep up anymore. I had to revert those changes for now.
I don't know what is causing this. Just telling facts.

Hacki95 · 2021-03-16T13:39:14Z

I'm not saying that what you reported is wrong, after all the damage IS higher than before! I am just trying to say that the new values are the actual values how they should be and the values before were very undertuned, making HC too easy.

https://wowwiki-archive.fandom.com/wiki/Lich_King_(Icecrown_Citadel_tactics) (Lich King in 25Normal hits for around 40k)

With the CLS system:

As you can see for 25normal he now does the expected damage. I sadly can't find a single source which states for how much meele damage the Lich King hits for in 25HC, but all other values seem to be correct (10, 10hc, 25).

It could be that the modificator for 25hc is simply wrong and needs some tuning, but so far I haven't found any information that points to this being the case.

If your players say they never saw such damage before then in my mind, they either only played on other AzerothCore based servers which ofcourse were all undertuned aswell before this PR.

Or if they were on TC based servers, then they must have manually nerfed bosses in HC.

Because with this in place we do exactly the same damage as TC. Which makes me think if the damage would have been wrong in TC for years surely there would be a bug report somewhere but there isn't.

I will try to get into contact with someone who might be able to confirm/deny if the Lich King really does so much damage in HC25.

Until then, this is an issue regarding the the damage_modifier, not the system itself. After this PR gets merged there will probably be quite a handful of mobs which need some sort of tuning.

@Knindzagxg were you able to do some tests yet? No more errors have been found so far.

Knindzagxg · 2021-03-16T16:03:46Z

For now it looks good.

What is really great about whole PR, that we can just change / modify damagemodifier if we need to fix some boss.
When it comes to dungeons that i tested, there is no to much changes and i actually like it - Kinda makes it a little harder due class changes.

What i wasn't able to test due my time are Demo Shouts.

Can someone test what happens with any boss damage when you use Bear or Warrior Demoralizing shout.
We had big issue with that as well, and i wonder will this PR make it work as it should.

Hacki95 · 2021-03-16T20:23:49Z

For now it looks good.

What is really great about whole PR, that we can just change / modify damagemodifier if we need to fix some boss.
When it comes to dungeons that i tested, there is no to much changes and i actually like it - Kinda makes it a little harder due class changes.

What i wasn't able to test due my time are Demo Shouts.

Can someone test what happens with any boss damage when you use Bear or Warrior Demoralizing shout.
We had big issue with that as well, and i wonder will this PR make it work as it should.

Expected damage without Demoralizing Shout:

Damage done:

Expected damage with Demoralizing Shout:

Damage done:

Looks like its working great!

PkllonG · 2021-03-17T11:21:36Z

Alone, my graduate defense Paladin 25H ICC
I don't know if the damage is high or low

mpfans · 2021-03-18T01:20:31Z

Alone, my graduate defense Paladin 25H ICC
I don't know if the damage is high or low

ICC老1需要分担伤害.所以这个测试我感觉没实际意义

Knindzagxg · 2021-03-18T06:08:38Z

Awesome, finally Shout working.

@pk will check ICC later tonight or tomorrow.

Hacki95 · 2021-03-18T08:53:44Z

Alone, my graduate defense Paladin 25H ICC
I don't know if the damage is high or low

It looks about right for HC

Knindzagxg · 2021-03-18T16:01:58Z

Damage looks fine pk.

Also, if possible when checking those, can u add small ss of your tanking stats, so we can see how it would work on lower geared / not defense capped and things like.

Hacki95 · 2021-03-18T20:56:02Z

@Knindzagxg @FrancescoBorzi Can this be marked as "to be merged" now? The system is thoroughly tested.

The only thing left are wrong damage_modifiers and those will be much easier to correct when the general public can get their hands on it. I'm not the right guy to ask for the correct DB values anyway.

Knindzagxg · 2021-03-19T06:04:03Z

Give it few more days, if not problem.

I wanna do few cross checking and to make few files about damage in raids mostly.
In case we gonna need to change some values i will have it ready.

Knindzagxg · 2021-03-19T15:42:33Z

Had some extra time today so files are ready in case we gonna need them.

This should improve overall damage -> Not much, but looks much better.

PS: In case there is an issue with some Boss, pretty please provide a bit more extra information (SS of your gear, defense, recount or etc - Will help a lot.)

mpfans · 2021-03-19T15:45:33Z

My server has 1500 + online players and has been tested for about 2 weeks. I think this PR can be merged. If you encounter incorrect damage, can fix it separately

Footman · 2021-03-20T10:58:05Z

My server has 1500 + online players and has been tested for about 2 weeks. I think this PR can be merged. If you encounter incorrect damage, can fix it separately

but you dont have them playing wotlk with ICC

Hacki95 · 2021-03-20T12:06:11Z

My server has 1500 + online players and has been tested for about 2 weeks. I think this PR can be merged. If you encounter incorrect damage, can fix it separately

but you dont have them playing wotlk with ICC

There is nothing pointing to ICC HC being broken, yes it was easier before but it also wasn't right.

If you want to make 25HC easier for your players simply tune down the damage_modifier of the offending bosses, but it also won't be blizzlike that way.

Hacki95 added 4 commits March 7, 2021 15:02

Fix double spaces in sql update

7d21578

Fix creature_template reload command

06e843e

Forgot to change the SELECT here

d682058

github-actions bot added CORE labels Mar 7, 2021

ghost reviewed Mar 7, 2021

View reviewed changes

src/server/game/Entities/Unit/StatSystem.cpp Show resolved Hide resolved

PkllonG reviewed Mar 7, 2021

View reviewed changes

src/server/scripts/Commands/cs_reload.cpp Outdated Show resolved Hide resolved

Hacki95 and others added 2 commits March 7, 2021 23:04

Fix DamageModifier values & Remove cInfo-> Entry

1235342

- Values from TC

Merge branch 'master' into cls_dmgfix

f2997ac

PkllonG reviewed Mar 8, 2021

View reviewed changes

Remove attackpower and rangedattackpower from creature_template

bf1ccd0

Fixed a mistake in cs_reload

631414b

PkllonG reviewed Mar 8, 2021

View reviewed changes

src/server/scripts/Commands/cs_reload.cpp Outdated Show resolved Hide resolved

Fix Snake Trap & Make cs_reload more compact

417837f

Hacki95 added 2 commits March 16, 2021 21:24

Merge branch 'master' into cls_dmgfix

49f1abb

Merge branch 'master' into cls_dmgfix

e140789

FrancescoBorzi removed the WIP label Mar 18, 2021

Merge branch 'master' into cls_dmgfix

f7d57a2

Knindzagxg approved these changes Mar 19, 2021

View reviewed changes

FrancescoBorzi added To Be Merged and removed Ready to be reviewed labels Mar 19, 2021

Si1ker added 2 commits March 19, 2021 14:50

Merge branch 'master' into cls_dmgfix

4c42750

Merge branch 'master' into cls_dmgfix

1ab7b69

Si1ker merged commit 2031e55 into azerothcore:master Mar 19, 2021

Hacki95 deleted the cls_dmgfix branch March 20, 2021 12:06

This was referenced Mar 20, 2021

Align creature_template with recent damage changes azerothcore/wiki#407

Closed

fix(creature-template): align to latest AC damage changes azerothcore/Keira3#1136

Merged

Hacki95 mentioned this pull request Mar 25, 2021

Update creature_template and creature_classlevelstats azerothcore/wiki#420

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(DB/Core) Fix the CLS damage system and update creature_classlevelstats #4749

fix(DB/Core) Fix the CLS damage system and update creature_classlevelstats #4749

Hacki95 commented Mar 7, 2021 •

edited

Loading

FrancescoBorzi commented Mar 7, 2021

PkllonG commented Mar 7, 2021 •

edited

Loading

T1ti commented Mar 7, 2021 •

edited

Loading

Hacki95 commented Mar 7, 2021

T1ti commented Mar 8, 2021 •

edited

Loading

Hacki95 commented Mar 8, 2021 •

edited

Loading

PkllonG Mar 8, 2021

Hacki95 Mar 8, 2021

PkllonG commented Mar 8, 2021

Hacki95 commented Mar 8, 2021

PkllonG commented Mar 8, 2021

PkllonG commented Mar 8, 2021

Hacki95 commented Mar 8, 2021

PkllonG commented Mar 8, 2021

Hacki95 commented Mar 8, 2021

PkllonG commented Mar 8, 2021

Footman commented Mar 16, 2021 •

edited

Loading

Hacki95 commented Mar 16, 2021

Knindzagxg commented Mar 16, 2021

Hacki95 commented Mar 16, 2021

PkllonG commented Mar 17, 2021 •

edited

Loading

mpfans commented Mar 18, 2021

Knindzagxg commented Mar 18, 2021

Hacki95 commented Mar 18, 2021

Knindzagxg commented Mar 18, 2021

Hacki95 commented Mar 18, 2021 •

edited

Loading

Knindzagxg commented Mar 19, 2021

Knindzagxg commented Mar 19, 2021

mpfans commented Mar 19, 2021 •

edited

Loading

Footman commented Mar 20, 2021

Hacki95 commented Mar 20, 2021

fix(DB/Core) Fix the CLS damage system and update creature_classlevelstats #4749

fix(DB/Core) Fix the CLS damage system and update creature_classlevelstats #4749

Conversation

Hacki95 commented Mar 7, 2021 • edited Loading

Fix the CLS damage calculation system and update creature_classlevelstats accordingly

Changes Proposed:

Issues Addressed:

Tests Performed:

How to Test the Changes:

Known Issues and TODO List:

Target Branch(es):

How to Test AzerothCore PRs

FrancescoBorzi commented Mar 7, 2021

PkllonG commented Mar 7, 2021 • edited Loading

T1ti commented Mar 7, 2021 • edited Loading

Hacki95 commented Mar 7, 2021

T1ti commented Mar 8, 2021 • edited Loading

Hacki95 commented Mar 8, 2021 • edited Loading

PkllonG Mar 8, 2021

Choose a reason for hiding this comment

Hacki95 Mar 8, 2021

Choose a reason for hiding this comment

PkllonG commented Mar 8, 2021

Hacki95 commented Mar 8, 2021

PkllonG commented Mar 8, 2021

PkllonG commented Mar 8, 2021

Hacki95 commented Mar 8, 2021

PkllonG commented Mar 8, 2021

Hacki95 commented Mar 8, 2021

PkllonG commented Mar 8, 2021

Footman commented Mar 16, 2021 • edited Loading

Hacki95 commented Mar 16, 2021

Knindzagxg commented Mar 16, 2021

Hacki95 commented Mar 16, 2021

PkllonG commented Mar 17, 2021 • edited Loading

mpfans commented Mar 18, 2021

Knindzagxg commented Mar 18, 2021

Hacki95 commented Mar 18, 2021

Knindzagxg commented Mar 18, 2021

Hacki95 commented Mar 18, 2021 • edited Loading

Knindzagxg commented Mar 19, 2021

Knindzagxg commented Mar 19, 2021

mpfans commented Mar 19, 2021 • edited Loading

Footman commented Mar 20, 2021

Hacki95 commented Mar 20, 2021

Hacki95 commented Mar 7, 2021 •

edited

Loading

PkllonG commented Mar 7, 2021 •

edited

Loading

T1ti commented Mar 7, 2021 •

edited

Loading

T1ti commented Mar 8, 2021 •

edited

Loading

Hacki95 commented Mar 8, 2021 •

edited

Loading

Footman commented Mar 16, 2021 •

edited

Loading

PkllonG commented Mar 17, 2021 •

edited

Loading

Hacki95 commented Mar 18, 2021 •

edited

Loading

mpfans commented Mar 19, 2021 •

edited

Loading