Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/locale): Import esES/esMX translations (Part 2) #5547

Merged
merged 2 commits into from May 6, 2021

Conversation

Delcidx
Copy link
Contributor

@Delcidx Delcidx commented Apr 29, 2021

Changes Proposed:

Issues Addressed:

  • Fix several spanish quests translations

SOURCE:

N/A

Tests Performed:

  • Tested in game

How to Test the Changes:

Check the quests with spanish client

Known Issues and TODO List:

  • [ ]
  • [ ]

Target Branch(es):

  • Master

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added the DB label Apr 29, 2021
@FrancescoBorzi
Copy link
Member

@Delcidx can you please split it into multiple files?

@Delcidx
Copy link
Contributor Author

Delcidx commented Apr 30, 2021

@Delcidx can you please split it into multiple files?

Sure, no problem.

@FrancescoBorzi FrancescoBorzi merged commit 64461da into azerothcore:master May 6, 2021
@Delcidx Delcidx deleted the Translations branch May 7, 2021 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants