Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core/DBC Move WorldSafeLocs.dbc storage to DB #932

Merged
merged 4 commits into from Jan 8, 2019
Merged

Core/DBC Move WorldSafeLocs.dbc storage to DB #932

merged 4 commits into from Jan 8, 2019

Conversation

Winfidonarleyan
Copy link
Member

@Winfidonarleyan Winfidonarleyan commented Jun 20, 2018 •
edited

Changes proposed:

  • Moved storage from WorldSafeLocs.dbc to DB
  • Added new command .reload game_graveyard

Target branch(es): master

Issues addressed: #584

Tests performed: Tested in game, tested in build. (Win 10 / VS 15 2017)

How to test the changes:

  1. Apply commit
  2. Rebuild Cmake
  3. Rebuild Project
  4. Try to die :)

TODO list:

  • Try to die in open world
  • Try to die in battlegroud
  • Try to die in instance

@BarbzYHOOL
Copy link
Member

Nice!!

@Winfidonarleyan
Fix erorrs
3081da0 
Enable header <ace/Singleton.h>
Enable headed file MapManager.h
Enable TeamID
@BarbzYHOOL
Copy link
Member

What is "WorldSafeLocs.dbc" used for by the client? the name of the graveyards?

@Winfidonarleyan
Copy link
Member Author

  • WorldSafeLocs.dbc - this game graveyard
  • Not used by the client

the name of the graveyards?

In what sense?

@BarbzYHOOL
Copy link
Member

"Not used by the client"

then why is it in the dbc xD i'm just curious because if we modify this without updating the dbc client side, we might miss something (in THEORY)

@FrancescoBorzi
Copy link
Member

is this ready to be tested?

@Winfidonarleyan
Copy link
Member Author

Yes

@wetbrownsauce
Copy link

Tested a bit

  • Tested new .reload game_graveyard by changing the z value of a graveyard to high up in the air, reloading with command, and then dying at that graveyard. Releasing correctly put me at the changed value. Command and reload work.

  • Died in a few zones in Kalimdor, Eastern Kingdoms, Outlands, Northrend. All took me to nearby graveyards as expected.

  • Died in a couple dungeons in each of the above areas, all took me to nearby graveyards.

  • Died in every battleground, all battleground graveyards seem functional.

I only tested on horde side, but no issues so far.

@BarbzYHOOL BarbzYHOOL changed the title Core/DBC Move WorldSafeLock.dbc storage to DB Core/DBC Move WorldSafeLocs.dbc storage to DB Dec 23, 2018
@BarbzYHOOL
Copy link
Member

Again, I'm asking if the DBC is used by the client for something (visually on the minimap for example)

DBC = database client if I recall

https://wowdev.wiki/DB/WorldSafeLocs

What happens if you remove the dbc client side too? no names on the graveyards?

@BarbzYHOOL
Copy link
Member

Can someone try to remove that dbc serverside and client side before we merge? just for curiosity lol

@BarbzYHOOL
Copy link
Member

@Winfidonarleyan what's this last commit? it's from another PR no?

@Winfidonarleyan
Copy link
Member Author

Yes

@FrancescoBorzi
Copy link
Member

can we merge this one?

@Winfidonarleyan
Copy link
Member Author

I think yes

@Viste Viste merged commit 1a9f8df into azerothcore:master Jan 8, 2019
@Winfidonarleyan Winfidonarleyan deleted the graveyard branch January 8, 2019 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nefertumm Nefertumm Nefertumm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Winfidonarleyan @BarbzYHOOL @FrancescoBorzi @wetbrownsauce @Nefertumm @Viste