Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/Spawning/Pathing) Eversong Woods cleanup and pathing #1 #9597

Merged
merged 4 commits into from
Dec 13, 2021
Merged

fix(DB/Spawning/Pathing) Eversong Woods cleanup and pathing #1 #9597

merged 4 commits into from
Dec 13, 2021

Conversation

malcrom
Copy link
Contributor

@malcrom malcrom commented Dec 8, 2021

Changes Proposed:

  • Remove some over spawning and add some missing spawns. Also added some missing pathing.

Issues Addressed:

SOURCE:

Official video and Sniff

Tests Performed:

  • No errors. Tested pathing in game and checked spawning.

How to Test the Changes:

  1. Install sql

@Yehonal Yehonal added the DB related to the SQL database label Dec 8, 2021
@malcrom malcrom added the 1-19 label Dec 8, 2021
@acidmanifesto
Copy link
Contributor

acidmanifesto commented Dec 8, 2021

To test

  1. .go c 56047 and observe pathing
  2. .go c 56888and observe pathing
  3. .go c 56871and observe pathing
  4. .go c 56878 and observe pathing
  5. go c 55624 and observe pathing
  6. go c 55619 and observe pathing
  7. go c 55639 and observe pathing
  8. go c 55607 and observe pathing
  9. go c 68083 and observe pathing
  10. go c 41792 and observe pathing
  11. go c 56173 and observe pathing
  12. go c 56221 and observe pathing
  13. go c 56405 and observe pathing
  14. go c 56404 and observe pathing
  15. go c 56403 and observe pathing

@ghost
Copy link

ghost commented Dec 8, 2021

.go c 56047

Strange Waypoint

image

Issue 1

After they aggro and kill a lynx on the side of the road, one of them went to the waypoint destination while another one resumed his last position. This happened due to one aggroing first and another one following up. Maybe because they're linked? However one of them waits for the other guard to come back to the waypoint and they sync once again. It's very trivial and probably not related to this PR anyways.

image
image
image

@ghost
Copy link

ghost commented Dec 9, 2021

Issue 2

Probably not related to this PR specifically but to the SmartAI, When waypoints are interrupted they don't resume, having NPCs stuck in places until the script triggers movement again, such as these cases:

image

@ghost
Copy link

ghost commented Dec 9, 2021

Issue 3

Also probably not related to this PR, but looks like these murlocs pathing are missing inhabit type for swim?
image

@ghost
Copy link

ghost commented Dec 9, 2021

Tested all the changes. Overall looks very good, other than the things I've mentioned. 👍🏽

@malcrom
Copy link
Contributor Author

malcrom commented Dec 9, 2021

Core handling of pathing is a separate thing. There is no inhabit type for swim in waypoint_data.

@acidmanifesto
Copy link
Contributor

Core handling of pathing is a separate thing. There is no inhabit type for swim in waypoint_data.

My inhabit removal pr that is pending will allow the creatures to path in water when given the swim ctm.

@Nyeriah Nyeriah merged commit 2b86d4b into azerothcore:master Dec 13, 2021
@malcrom malcrom deleted the Eversong-Cleanup-1 branch December 23, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-19 DB related to the SQL database To Be Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants