fix(Core/Entities): Extend combo point system to all Units. Source: T… #9816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UltraNix
added
ChromieCraft Generic
Yehonal
added
CORE
|
Tested |
eyeofstorm
added a commit
to eyeofstorm/azerothcore-wotlk
that referenced
this pull request
Jan 8, 2022
* master: (219 commits) chore(DB): import pending files fix(DB/GameEvents): Added missing spawn of Melnan Darkstone. Source: TrinityCore. (azerothcore#9657) chore(DB): import pending files fix(DB/GameEvents): new game event Darkmoon Faire Building (Terokkar Forest)(azerothcore#9654) fix(Core/Entities): extend combo point system to all Units (azerothcore#9816) feat(Core/SmartScripts): SMART_ACTION_ATTACK_STOP azerothcore#10053 fix(Core/Handlers): remove the uint8 cap from guild bank max stacks per day chore(DB): import pending files fix(DB/Pathing) Swamp of Sorrow (azerothcore#10042) fix(Scripts/Creature): Convert npc_ranger_lilatha script to RegisterCreatureAI (azerothcore#10043) chore(DB): import pending files fix(DB/Pathing): Westfall (azerothcore#10046) fix(DB/Pathing): Darkshire (azerothcore#10044) chore(DB): import pending files fix(Core/Creature): Fire Elemental Invasion changes (azerothcore#9372) refactor(Core/Misc): sin() to std::sin() (azerothcore#9795) fix(MMAP): Build ADT floor just like WMO floor below liquid (azerothcore#9990) chore(DB): import pending files fix(DB/Script): Eastvale Logging Camp, Elywnn Forest (azerothcore#10036) chore(DB): import pending files ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rinityCore.
Fixes #1140
Issues Addressed:
Tests Performed:
How to Test the Changes:
Enter Eye of Eternity 10 or 25 players
Engage Malygos
Go to P2 and take a disk with combos points class (rogue or druid)
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.