fix(DB/Creature): Centipaar Tunneler attack on summon #9989

febaut · 2022-01-03T21:46:23Z

Centipaar Tunnelers from Water Survey quest now attack the player after collecting samples.

The issue suggests that maybe is a missing InhabitType but is not, tried adding water and still the same.

Changes Proposed:

Adding a new SMART SCRIPT to Centipaar Tunneler. Entry: 5459

Issues Addressed:

Closes Centipaar Tunneler NPCs of Gadgetzan Water Survey quest doesn't attack player #9984

SOURCE:

Tests Performed:

How to Test the Changes:

Add the smart script row
.go xyz -7218 -2913 6.5 1 1
.additem 8584
Use the item. The mobs should insta attack you.

Known Issues and TODO List:

[ ]
[ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

Centipaar Tunnelers now attack the player after collecting samples. I preferred "Move one Yard" rather "Attack Start" cause it causes a double auto attack each mob meaning a lot of damage.

acidmanifesto · 2022-01-03T23:52:45Z

data/sql/updates/pending_db_world/rev_1641245804524923284.sql

@@ -0,0 +1,3 @@
+INSERT INTO `version_db_world` (`sql_rev`) VALUES ('1641245804524923284');
+
+INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES (5459, 0, 2, 0, 54, 0, 100, 0, 0, 0, 0, 0, 0, 46, 1, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 'Centipaar Tunneler - On Just Summoned - Move Forward 1 Yards');


INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES (5459, 0, 2, 0, 54, 0, 100, 0, 0, 0, 0, 0, 0, 46, 1, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 'Centipaar Tunneler - On Just Summoned - Move Forward 1 Yards');

Add line Break for readability. One extremely long line does make things a bit problematic on the human eye and other reviewers. We prefer to keep it all on one page.

Thanks a lot. Will take it into account next time.

Not next time. This time.

Also you always need to a DELETE statement before an INSERT (Only exception being for the sql_rev thing)
You can learn more about SQL stuff here https://www.azerothcore.org/wiki/sql-standards :)

Nyeriah · 2022-01-04T00:22:40Z

Centipaar Tunnelers from Water Survey quest now attack the player after collecting samples.
I preferred "Move one Yard" rather "Attack Start" cause it causes a double auto attack each mob meaning a lot of damage.

This assumption is not correct, attack start won't cause them to hit you twice, it just tells the creature to start attacking you. In this specific case, you could use the action to start attacking the summoner.

febaut · 2022-01-04T01:02:49Z

Is not an "assumption". Please go and try with attack start. You'll get 4 hits at once instead of 2.

Kitzunu · 2022-01-04T01:03:36Z

This is not an acceptable fix. This is a hack.

If there now is an issue with Attack Start then we should fix that. And not hack fix through things in the database.

febaut · 2022-01-04T01:30:45Z

Updated with Start Attacking. Thanks for the recommendations. A bit rude to someone that is just trying to help, but if it's usless, okay ^^.

Kitzunu · 2022-01-04T01:50:20Z

I apologize if I seemed rude. I appreciate the effort. But this is not the right way of fixing the issue

acidmanifesto · 2022-01-04T19:37:32Z

Added Need Sniff label for further clarification in how it should be handled.

Nyeriah · 2022-01-04T19:41:39Z

If the creature attacks the summoner this is fine. I don’t understand what needs to be sniffed about this. The only part incorrect about this PR was forcing the creature move on top of the player to trigger the attack reaction instead of doing it through the summon event.

Annamaria-CC · 2022-01-05T08:56:53Z

@febaut

Thanks you so much for your contribution! I have tested it and it is working as described!

acidmanifesto · 2022-01-05T14:45:24Z

@febaut

Thanks you so much for your contribution! I have tested it and it is working as described!

The Sql still needs to be adjust and we need a delete query as well before the insert.

febaut · 2022-01-05T14:48:30Z

@febaut
Thanks you so much for your contribution! I have tested it and it is working as described!

The Sql still needs to be adjust and we need a delete query as well before the insert.

I did the changes already.

acidmanifesto · 2022-01-05T14:54:17Z

@febaut
Thanks you so much for your contribution! I have tested it and it is working as described!

The Sql still needs to be adjust and we need a delete query as well before the insert.

I did the changes already.

I do apologize. I really did not see the delete line at all when i made the comment. hitting refresh a couple of times after another staffer informed me it was there, it then showed.
Thank you for the PR.

Nyeriah · 2022-01-05T16:52:38Z

Thanks for your PR! 🚀

fix(DB/Creature): Centipaar Tunneler attack on summon

56594eb

Centipaar Tunnelers now attack the player after collecting samples. I preferred "Move one Yard" rather "Attack Start" cause it causes a double auto attack each mob meaning a lot of damage.

Yehonal added the DB related to the SQL database label Jan 3, 2022

acidmanifesto suggested changes Jan 3, 2022

View reviewed changes

Update rev_1641245804524923284.sql

10d1dae

acidmanifesto added the Needs sniff The issue/PR needs sniff data to be corrected. label Jan 4, 2022

Nyeriah added Ready to be Reviewed Waiting to be Tested and removed Needs sniff The issue/PR needs sniff data to be corrected. labels Jan 4, 2022

Annamaria-CC added the Testing in Progress label Jan 5, 2022

Annamaria-CC added To Be Merged and removed Testing in Progress Waiting to be Tested labels Jan 5, 2022

acidmanifesto removed the To Be Merged label Jan 5, 2022

febaut requested a review from acidmanifesto January 5, 2022 14:50

acidmanifesto approved these changes Jan 5, 2022

View reviewed changes

Nyeriah merged commit 1020cf1 into azerothcore:master Jan 5, 2022

Gultask mentioned this pull request Apr 29, 2022

Centipaar Tuneler stuck after using Tapped Dowsing Widget chromiecraft/chromiecraft#2715

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(DB/Creature): Centipaar Tunneler attack on summon #9989

fix(DB/Creature): Centipaar Tunneler attack on summon #9989

febaut commented Jan 3, 2022 •

edited

Loading

acidmanifesto Jan 3, 2022 •

edited

Loading

acidmanifesto Jan 3, 2022

febaut Jan 4, 2022

Kitzunu Jan 4, 2022 •

edited

Loading

Nyeriah commented Jan 4, 2022

febaut commented Jan 4, 2022

Kitzunu commented Jan 4, 2022

febaut commented Jan 4, 2022

Kitzunu commented Jan 4, 2022

acidmanifesto commented Jan 4, 2022

Nyeriah commented Jan 4, 2022

Annamaria-CC commented Jan 5, 2022

acidmanifesto commented Jan 5, 2022

febaut commented Jan 5, 2022

acidmanifesto commented Jan 5, 2022

Nyeriah commented Jan 5, 2022

		@@ -0,0 +1,3 @@
		INSERT INTO `version_db_world` (`sql_rev`) VALUES ('1641245804524923284');

		INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `event_param5`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_param4`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES (5459, 0, 2, 0, 54, 0, 100, 0, 0, 0, 0, 0, 0, 46, 1, 0, 0, 0, 0, 0, 7, 0, 0, 0, 0, 0, 0, 0, 0, 'Centipaar Tunneler - On Just Summoned - Move Forward 1 Yards');

fix(DB/Creature): Centipaar Tunneler attack on summon #9989

fix(DB/Creature): Centipaar Tunneler attack on summon #9989

Conversation

febaut commented Jan 3, 2022 • edited Loading

Changes Proposed:

Issues Addressed:

SOURCE:

Tests Performed:

How to Test the Changes:

Known Issues and TODO List:

How to Test AzerothCore PRs

acidmanifesto Jan 3, 2022 • edited Loading

Choose a reason for hiding this comment

acidmanifesto Jan 3, 2022

Choose a reason for hiding this comment

febaut Jan 4, 2022

Choose a reason for hiding this comment

Kitzunu Jan 4, 2022 • edited Loading

Choose a reason for hiding this comment

Nyeriah commented Jan 4, 2022

febaut commented Jan 4, 2022

Kitzunu commented Jan 4, 2022

febaut commented Jan 4, 2022

Kitzunu commented Jan 4, 2022

acidmanifesto commented Jan 4, 2022

Nyeriah commented Jan 4, 2022

Annamaria-CC commented Jan 5, 2022

acidmanifesto commented Jan 5, 2022

febaut commented Jan 5, 2022

acidmanifesto commented Jan 5, 2022

Nyeriah commented Jan 5, 2022

febaut commented Jan 3, 2022 •

edited

Loading

acidmanifesto Jan 3, 2022 •

edited

Loading

Kitzunu Jan 4, 2022 •

edited

Loading