Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http server chops-off content posted by client? #837

Closed
itadapter opened this issue Mar 8, 2023 · 6 comments
Closed

Http server chops-off content posted by client? #837

itadapter opened this issue Mar 8, 2023 · 6 comments
Assignees
Labels
- RTM - Released to manufacturing AREA-WAVE Wave/Web bug Something isn't working CRITICAL Critical Issue affecting the whole system

Comments

@itadapter itadapter added bug Something isn't working CRITICAL Critical Issue affecting the whole system AREA-WAVE Wave/Web labels Mar 8, 2023
@itadapter itadapter self-assigned this Mar 8, 2023
@itadapter
Copy link
Contributor Author

WorkContext.DoGetRequestBodyAsJsonDataMapAsync was quickly refactored when we introduced pluggable listeners.
Most likely the async stream is read in a sync fashion and this leads to loss of data?

@itadapter
Copy link
Contributor Author

@g8sun
Copy link

g8sun commented Mar 15, 2023

20230315-161652.188, b74ed7e8-b890-4b6c-a92b-5c99c703138a, dsys-app-01, Error, WAVE, Azos.Wave.Filters.ErrorFilter, [Azos.Wave.FilterPipelineException] >>error>backend-info>realip>callflow>Portal>session>dconv>latency>cors> [Azos.Wave.MvcException] MVC handler error in work processing: [Azos.Web.HTTPStatusException] 400 - Bad Request body : [Azos.Serialization.JSON.Backends.JazonDeserializationException] Code eUnterminatedObject at Line: 1 Col: 3845 Char: 3845 {batch{Data[#0{ near 0\\\",\\\"--info-level\\\":\\\"1\\\",\\\"allow\\\":{\\\"entity\\\":\\\"*\\\"}}},\\\"Verification\\\":{\\\"EmailVerification\\\":: Unterminated object

@g8sun
Copy link

g8sun commented Mar 15, 2023

It is very payload-sensitive. 3947 fails, 3948 does not, then a bit more payload fails again

@itadapter
Copy link
Contributor Author

itadapter commented Mar 16, 2023

#731 (comment)

The problem is: Kestrel/ASP infrastructure does not work properly (sometimes) using StreamReader in sync mode, even when AllowSyncIO=true. It is an intermittent condition that looks like a race condition in MSFT code.

For now, we have introduced dbl buffering by reading the JSON body a whole into a string variable, then parsing it synchronously.
Until #731 is implemented, the copy will be necessary as a workaround for a MSFT bug.

@itadapter itadapter added the - RTM - Released to manufacturing label Mar 27, 2023
@itadapter
Copy link
Contributor Author

#731 is implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- RTM - Released to manufacturing AREA-WAVE Wave/Web bug Something isn't working CRITICAL Critical Issue affecting the whole system
Projects
None yet
Development

No branches or pull requests

2 participants