Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move psalm plugin to a seperate package #166

Closed
2 of 3 tasks
azjezz opened this issue Mar 24, 2021 · 3 comments · Fixed by #170
Closed
2 of 3 tasks

move psalm plugin to a seperate package #166

azjezz opened this issue Mar 24, 2021 · 3 comments · Fixed by #170
Assignees
@azjezz
Labels
Priority: Critical This should be dealt with ASAP. Not fixing this issue would be a serious error. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity
Milestone
1.6.0

Comments

@azjezz
Copy link
Owner

azjezz commented Mar 24, 2021 •
edited
Loading

psalm plugin should be moved to it's own repository ( https://github.com/php-standard-library/psalm-plugin )

TODO:

  • move the plugin to it's own repository and change the namespace to Psl\Psalm ( instead of Psl\Integration\Psl )
  • deprecate the current plugin and recommend installing the package instead.
  • remove the plugin located in this repository in v2.0
@azjezz azjezz added Priority: Critical This should be dealt with ASAP. Not fixing this issue would be a serious error. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity labels Mar 24, 2021
@azjezz azjezz self-assigned this Mar 24, 2021
@veewee
Copy link
Collaborator

veewee commented Mar 24, 2021

Why should it be a separate package?

@azjezz
Copy link
Owner Author

azjezz commented Mar 24, 2021

to drop psalm from dev dependency in this project, and use the phar instead.

the reason to drop psalm: https://github.com/azjezz/psl/tree/asio/src/Psl/Asio/Internal#amphp-event-loop

@azjezz
Copy link
Owner Author

azjezz commented Mar 24, 2021

not sure if we would use the phar, or have a dedicated directory to install dev tools, either way, we can't keep it in require-dev

@azjezz azjezz mentioned this issue Mar 27, 2021
Merged
@azjezz azjezz modified the milestones: 1.6.0, 2.0.0 Mar 27, 2021
@azjezz azjezz reopened this Mar 27, 2021
@azjezz azjezz closed this as completed Mar 27, 2021
@azjezz azjezz modified the milestones: 2.0.0, 1.6.0 Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azjezz azjezz

Labels
Priority: Critical This should be dealt with ASAP. Not fixing this issue would be a serious error. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Type: Maintenance Updating phrasing or wording to make things clearer or removing ambiguity
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

recommand using the psalm-plugin package over builtin integration azjezz/psl
2 participants
@veewee @azjezz