Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split this package is multiple sub-packages #419

Closed
BafS opened this issue Jul 27, 2023 · 2 comments
Closed

Split this package is multiple sub-packages #419

BafS opened this issue Jul 27, 2023 · 2 comments
Assignees
Labels
Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@BafS
Copy link

BafS commented Jul 27, 2023

Is your feature request related to a problem? Please describe.

Currently this library can be required using azjezz/psl, the "issue" is that it comes with everything. I think it would be nice to choose more precisely what we need from this library, as it provides a lot of helpers. Typically if you work in a framework context you may already have tools for File/FileSystem/Env/Str/Encoding/etc. and it can be confusing to autocomplete and have multiple times the same class name.

Describe the solution you'd like

Having a git subtree would be great, like that we could use azjezz/psl-math to only have the Math part. Of course azjezz/psl would still provides all the packages.

To give an example of a repository doing this: https://github.com/symfony/contracts

@BafS BafS added the Type: Enhancement Most issues will probably ask for additions or changes. label Jul 27, 2023
@azjezz
Copy link
Owner

azjezz commented Jul 27, 2023

I'm not totally against the idea, however, the amount of time required to implement this would be huge, one of which i cannot afford right now, so it is extremely unlike to happen.

aside from a git sub-tree, we would need to analyze each component to determine what are it's dependencies, and declare them in it's own composer.json file, on top of that, we also have a lot of circle-dependencies between components, which would also cause issues.

This also adds to the maintenance cost of the library, because we would need to be careful about what to use in each component.

Overall, it is not worth it. you can simple configure your IDEA to ignore directories of components that you do not use.

@azjezz
Copy link
Owner

azjezz commented Mar 24, 2024

Closing, as we do not have a plan to do this now for the reasons stated above.

@azjezz azjezz closed this as completed Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Development

No branches or pull requests

2 participants