Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Iter] split reduce into multiple functions #73

Closed
veewee opened this issue Oct 3, 2020 · 1 comment · Fixed by #84
Closed

[Iter] split reduce into multiple functions #73

veewee opened this issue Oct 3, 2020 · 1 comment · Fixed by #84
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Available No one has claimed responsibility for resolving this issue. Type: Enhancement Most issues will probably ask for additions or changes.
Milestone
0.1.0

Comments

@veewee
Copy link
Collaborator

veewee commented Oct 3, 2020 •
edited
Loading

Currently the Iter\reduce function acts as a reduce_with_keys. Is there a specific reason for this or is it safe to split it into reduce, reduce_keys and reduce_with_keys function?

https://github.com/azjezz/psl/blob/develop/src/Psl/Iter/reduce.php
@veewee veewee added the Type: Enhancement Most issues will probably ask for additions or changes. label Oct 3, 2020
@azjezz
Copy link
Owner

azjezz commented Oct 3, 2020

You are right, I think we should split this.

@azjezz azjezz added this to the v1.0.0 milestone Oct 3, 2020
@azjezz azjezz added Priority: Medium This issue may be useful, and needs some attention. Status: Available No one has claimed responsibility for resolving this issue. labels Oct 3, 2020
@azjezz azjezz removed their assignment Oct 3, 2020
@azjezz azjezz changed the title Consistent iter\reduce function [Iter] split reduce into multiple function Oct 3, 2020
@azjezz azjezz changed the title [Iter] split reduce into multiple function [Iter] split reduce into multiple functions Oct 3, 2020
@veewee veewee mentioned this issue Oct 7, 2020
Merged
3 tasks
@azjezz azjezz closed this as completed in #84 Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Available No one has claimed responsibility for resolving this issue. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

[Iter] split reduce into multiple functions veewee/psl
2 participants
@veewee @azjezz