Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Collection] Vector and Map are not @psalm-immutable #91

Closed
azjezz opened this issue Oct 20, 2020 · 2 comments
Closed

[Collection] Vector and Map are not @psalm-immutable #91

azjezz opened this issue Oct 20, 2020 · 2 comments
Assignees
@azjezz
Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Milestone
1.5.0

Comments

@azjezz
Copy link
Owner

azjezz commented Oct 20, 2020

All collection interfaces + Vector and Map class should be marked with @psalm-immutable
@azjezz azjezz added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Available No one has claimed responsibility for resolving this issue. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Oct 20, 2020
@azjezz azjezz added this to the v1.0.0 milestone Oct 20, 2020
@azjezz azjezz self-assigned this Oct 20, 2020
@azjezz
Copy link
Owner Author

azjezz commented Oct 20, 2020

The reasons I didn't tag the immutable at first is that Vector and Map used a lot of Iter\ and Arr\ functions that weren't pure.

but I think we can do this now.

@azjezz azjezz modified the milestones: 0.1.0, 1.0.0 Oct 30, 2020
@azjezz azjezz modified the milestones: 2.0.0, 1.5.0 Mar 9, 2021
@azjezz azjezz added Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes. and removed Status: Available No one has claimed responsibility for resolving this issue. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Mar 9, 2021
@azjezz
Copy link
Owner Author

azjezz commented Mar 9, 2021

most methods are now mutation free and a new named ctor ( fromArray ) that is pure has been added, meaning collections can be used in a pure context.

@azjezz azjezz closed this as completed Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed by the requestor out of politeness Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
1 participant
@azjezz