Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flow trigger UI #1648

Merged
merged 6 commits into from
Feb 21, 2018
Merged

Conversation

burgerkingeater
Copy link
Contributor

@burgerkingeater burgerkingeater commented Feb 17, 2018

This PR adds an UI page to display current scheduled flow trigger:
image

@@ -508,6 +509,7 @@ private void configureRoutes() throws TriggerManagerException {
root.addServlet(new ServletHolder(new StatusServlet(this.statusService)), "/status");
root.addServlet(new ServletHolder(new NoteServlet()), "/notes");
root.addServlet(new ServletHolder(new FlowTriggerInstanceServlet()), "/flowtriggerinstance");
root.addServlet(new ServletHolder(new FlowTriggerServlet()), "/flowtrigger");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a button for click to jump to the page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently no, but will add it in future.

@@ -0,0 +1,60 @@
/*
* Copyright 2012 LinkedIn Corp.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2018

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

});
</script>
<script>
function showTriggerProperties(flowTrigger) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@@ -0,0 +1,173 @@
#*
* Copyright 2012 LinkedIn Corp.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2018

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Contributor

@kunkun-tang kunkun-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add the tab button when the UI is ready.

@burgerkingeater burgerkingeater merged commit 3380267 into azkaban:master Feb 21, 2018
@burgerkingeater burgerkingeater deleted the flowtriggerscheduleui branch February 21, 2018 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants