-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flow trigger UI #1648
flow trigger UI #1648
Conversation
@@ -508,6 +509,7 @@ private void configureRoutes() throws TriggerManagerException { | |||
root.addServlet(new ServletHolder(new StatusServlet(this.statusService)), "/status"); | |||
root.addServlet(new ServletHolder(new NoteServlet()), "/notes"); | |||
root.addServlet(new ServletHolder(new FlowTriggerInstanceServlet()), "/flowtriggerinstance"); | |||
root.addServlet(new ServletHolder(new FlowTriggerServlet()), "/flowtrigger"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a button for click to jump to the page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently no, but will add it in future.
@@ -0,0 +1,60 @@ | |||
/* | |||
* Copyright 2012 LinkedIn Corp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
}); | ||
</script> | ||
<script> | ||
function showTriggerProperties(flowTrigger) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
@@ -0,0 +1,173 @@ | |||
#* | |||
* Copyright 2012 LinkedIn Corp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please add the tab button when the UI is ready.
This PR adds an UI page to display current scheduled flow trigger: