Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flow trigger service enhancement #1686

Merged
merged 21 commits into from
Mar 22, 2018
Merged

flow trigger service enhancement #1686

merged 21 commits into from
Mar 22, 2018

Conversation

burgerkingeater
Copy link
Contributor

@burgerkingeater burgerkingeater commented Mar 12, 2018 •
edited
Loading

This PR includes several flow trigger service enhancement:

  1. Run cancelling of context asynchronously given the possibility where cancelling context is subject to blocking.
  2. Sending failure email asynchronously when flow trigger instance fails given email sending is blocking operation.
  3. Flow trigger instance of such case won't be rerun when web server restarts: flow trigger instances succeed, but fails to trigger flow execution.

kunkun-tang
kunkun-tang reviewed Mar 22, 2018
View reviewed changes
Copy link
Contributor

@kunkun-tang kunkun-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced up offline. LGTM!

@burgerkingeater burgerkingeater merged commit 4c66c37 into azkaban:master Mar 22, 2018
@burgerkingeater burgerkingeater deleted the flowtriggerslowupdate branch March 22, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunkun-tang kunkun-tang kunkun-tang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burgerkingeater @kunkun-tang