Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address feedback from #1803 #1812

Merged
merged 3 commits into from
Jun 20, 2018
Merged

address feedback from #1803 #1812

merged 3 commits into from
Jun 20, 2018

Conversation

burgerkingeater
Copy link
Contributor

@burgerkingeater burgerkingeater commented Jun 20, 2018 •
edited
Loading

see comments from #1803

  1. change configurable key name
  2. change default value for max cache size to 128GB which is a more standard number.
  3. change default value for stop cleanup threshold to 60 to allow more space to be freed.
  4. change data type of stop cleanup threshold from double to int.
  5. rename the parameter name(projectDirMaxSizeInMB - > projectDirMaxSizeInMb) to align with coding standard.

@burgerkingeater burgerkingeater changed the title address feedback from https://github.com/azkaban/azkaban/pull/1803 address feedback from #1803 Jun 20, 2018
kunkun-tang
kunkun-tang approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@kunkun-tang kunkun-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not having the full context, but approving to catch up the upcoming release

@kunkun-tang kunkun-tang merged commit e9dfd50 into azkaban:master Jun 20, 2018
@burgerkingeater burgerkingeater deleted the projectLRU branch June 20, 2018 20:34
@HappyRay
Copy link
Contributor

Is it safer to turn off this feature by default? Otherwise, users including us may get surprised with the current default behavior.

@burgerkingeater burgerkingeater mentioned this pull request Jun 21, 2018
Merged
burgerkingeater added a commit to burgerkingeater/azkaban that referenced this pull request Jul 9, 2018
@burgerkingeater
Revert "address feedback from azkaban#1803 (azkaban#1812)"
3939033 
This reverts commit e9dfd50.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunkun-tang kunkun-tang kunkun-tang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burgerkingeater @HappyRay @kunkun-tang