Flakey FlowRunnerYamlTest #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 26, 2019 18:07
…ow status About once every 200 executions on my machine this test was failing due to the flow being killed instead of failed because jobs A and B were still in the running state when the flow finished. Waiting for the flow to catch up with their failures before letting job C succeed (hopefully) eliminates this possibility.
I was seeing occasional test failures due to multiple concurrent runner threads. In particular I was sseing a failure of testAlertOnFlowFinished due to missing the alertOnError call, which actually did happen but only after the test had finished. Waiting for the thread the exit before verifying that the call occurred makes this more reliable.
Codecov Report
@@ Coverage Diff @@
## master #2160 +/- ##
============================================
+ Coverage 33.87% 33.88% +0.01%
- Complexity 2815 2817 +2
============================================
Files 421 421
Lines 29859 29859
Branches 3780 3780
============================================
+ Hits 10114 10118 +4
+ Misses 18842 18839 -3
+ Partials 903 902 -1
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 4424
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of reasons for FlowRunnerYamlTest failing intermittently.