UpdateVersion and deleteRule API for RampManager #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Version for existing RampRule will update version metadata on DB directly; while delete rule will delete all metadata related to the rule. Both API would not introduce new insert but only update existing data. Failure would occur when: - no existing rule - input failed validation - no user permission
Codecov Report
@@ Coverage Diff @@
## master #3159 +/- ##
============================================
- Coverage 41.78% 41.69% -0.10%
- Complexity 4754 4768 +14
============================================
Files 607 610 +3
Lines 40663 40875 +212
Branches 4717 4738 +21
============================================
+ Hits 16992 17042 +50
- Misses 22260 22417 +157
- Partials 1411 1416 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
djaiswal83
reviewed
Sep 27, 2022
azkaban-common/src/main/java/azkaban/imagemgmt/daos/RampRuleDaoImpl.java
Outdated
Show resolved
Hide resolved
djaiswal83
reviewed
Sep 27, 2022
azkaban-common/src/main/java/azkaban/imagemgmt/daos/RampRuleDaoImpl.java
Show resolved
Hide resolved
djaiswal83
reviewed
Sep 27, 2022
| public void deleteRule(final String ruleName, final User user) { | ||
| // validate permission | ||
| final Set<String> owners = rampRuleDao.getOwners(ruleName); | ||
| if (!permissionManager.hasPermission(user, owners)) { |
There was a problem hiding this comment.
This and code block at line 255 are duplicate. Please dedupe.
djaiswal83
requested changes
Sep 27, 2022
djaiswal83
approved these changes
Sep 28, 2022
NancyXie2022
pushed a commit
that referenced
this pull request
May 26, 2023
* UpdateVersion and deleteRule API for RampManager Update Version for existing RampRule will update version metadata on DB directly; while delete rule will delete all metadata related to the rule. Both API would not introduce new insert but only update existing data. Failure would occur when: - no existing rule - input failed validation - no user permission PR link: #3159 RB=3643970 G=azkabandev-reviewers R=sarumuga,prkhande,ypadron,jakhani,anath1,areznik,sshardoo,apruthi,angoel,abtiwari,adsharma,gsalia,djaiswal A=shwei
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Version for existing RampRule will update version metadata on DB directly; while delete rule will delete all metadata related to the rule. Both API would not introduce new insert but only update existing data. Failure would occur when: