Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stacktrace when exception occurs in ExecutorServlet because user can check log. #905

Merged
merged 1 commit into from Feb 14, 2017
Merged

Add stacktrace when exception occurs in ExecutorServlet because user can check log. #905

merged 1 commit into from Feb 14, 2017

Conversation

wyukawa
Copy link
Collaborator

@wyukawa wyukawa commented Feb 13, 2017

No description provided.

@HappyRay
Copy link
Contributor

If I understand your change correctly, you are adding stack trace to the log. Previously only the exception message is logged. Am I right? If so, could you clarify in your commit message?

@wyukawa wyukawa changed the title Add logging when exception occurs in ExecutorServlet because user can check log. Add stacktrace when exception occurs in ExecutorServlet because user can check log. Feb 14, 2017
@wyukawa
Copy link
Collaborator Author

wyukawa commented Feb 14, 2017

You are right. I changed the commit message.

Only exception message is not enought to debug.
Stacktrace is also important to debug.

By the way,when I encountered the following error, I did't understand the cause well.
This is the reason why I sent this pull request.

2017-02-09 16:08:38 INFO  ExecutorServlet:120 - User  has called action log on 3285
2017-02-09 16:08:38 ERROR ExecutorServlet:191 - azkaban.executor.ExecutorManagerException: Running flow 3285 not found.
2017-02-09 16:08:38 INFO  ExecutorServlet:120 - User  has called action log on 3285
2017-02-09 16:08:38 ERROR ExecutorServlet:191 - azkaban.executor.ExecutorManagerException: Running flow 3285 not found.

At this time, azkaban job was successful, it was not problem.
I guess this error is the concurrency problem related to ConcurrentHashMap(runningFlows).

@HappyRay HappyRay merged commit 0e64646 into azkaban:master Feb 14, 2017
@HappyRay
Copy link
Contributor

Thanks

@wyukawa wyukawa deleted the exception-logging branch February 14, 2017 23:31
@wyukawa
Copy link
Collaborator Author

wyukawa commented Feb 14, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants