Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate logical and physical state in ItemSpec. #70

Merged
merged 8 commits into from
Jan 13, 2023

Conversation

azriel91
Copy link
Owner

Closes #69.

@azriel91 azriel91 force-pushed the feature/69/consolidate-item-spec-state branch from 775e1e4 to cfd9d69 Compare January 13, 2023 03:17
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 91.66% // Head: 92.44% // Increases project coverage by +0.78% 🎉

Coverage data is based on head (cfd9d69) compared to base (7aa8861).
Patch coverage: 96.12% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   91.66%   92.44%   +0.78%     
==========================================
  Files         220      210      -10     
  Lines       13814    13534     -280     
==========================================
- Hits        12663    12512     -151     
+ Misses       1151     1022     -129     
Impacted Files Coverage Δ
crate/cfg/src/state.rs 92.30% <ø> (ø)
crate/rt_model/src/item_spec_boxed.rs 100.00% <ø> (ø)
crate/rt_model/src/outcomes/item_ensure.rs 98.33% <ø> (ø)
crate/rt_model/src/outcomes/item_ensure_partial.rs 100.00% <ø> (ø)
item_specs/sh_cmd/src/sh_cmd_clean_op_spec.rs 65.57% <ø> (ø)
item_specs/sh_cmd/src/sh_cmd_item_spec.rs 94.11% <ø> (ø)
item_specs/tar_x/src/tar_x_item_spec.rs 92.30% <ø> (ø)
item_specs/tar_x/src/tar_x_clean_op_spec.rs 19.51% <33.33%> (-1.42%) ⬇️
crate/cfg/src/state/external.rs 44.44% <44.44%> (ø)
item_specs/tar_x/src/tar_x_ensure_op_spec.rs 74.66% <55.55%> (ø)
... and 42 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@azriel91 azriel91 merged commit c748c0f into main Jan 13, 2023
@azriel91 azriel91 deleted the feature/69/consolidate-item-spec-state branch January 13, 2023 03:32
@azriel91 azriel91 mentioned this pull request Mar 5, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use single State associated type in item spec
1 participant